lib/src/protobuf/unknown_field_set.dart - Issue 1277863003: cleanup: move fieldType constants and functions to a separate file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/protobuf/unknown_field_set.dart

Issue 1277863003: cleanup: move fieldType constants and functions to a separate file (Closed) Base URL: git@github.com:dart-lang/dart-protobuf.git@master

Patch Set: _validateMessage should call _baseType, not callers Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/src/protobuf/unknown_field_set.dart

diff --git a/lib/src/protobuf/unknown_field_set.dart b/lib/src/protobuf/unknown_field_set.dart

index 7ce2fa40fb8a002ebd2da15b31d989a3f0539221..3f56517b6715649755fc87fe84b46e6a436440b2 100644

--- a/lib/src/protobuf/unknown_field_set.dart

+++ b/lib/src/protobuf/unknown_field_set.dart

@@ -223,11 +223,11 @@ class UnknownFieldSetField {

output.writeField(fieldNumber, type, value);

}

- write(GeneratedMessage._REPEATED_UINT64, varints);

- write(GeneratedMessage._REPEATED_FIXED32, fixed32s);

- write(GeneratedMessage._REPEATED_FIXED64, fixed64s);

- write(GeneratedMessage._REPEATED_BYTES, lengthDelimited);

- write(GeneratedMessage._REPEATED_GROUP, groups);

+ write(FieldType._REPEATED_UINT64, varints);

+ write(FieldType._REPEATED_FIXED32, fixed32s);

+ write(FieldType._REPEATED_FIXED64, fixed64s);

+ write(FieldType._REPEATED_BYTES, lengthDelimited);

+ write(FieldType._REPEATED_GROUP, groups);

}

void addGroup(UnknownFieldSet value) {

« no previous file with comments | « lib/src/protobuf/generated_message.dart ('k') | lib/src/protobuf/wire_format.dart » ('j') | no next file with comments »