Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: build/isolate.gypi

Issue 12775012: Change test_isolation_mode default from noop to check (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebasing Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/isolate.gypi
diff --git a/build/isolate.gypi b/build/isolate.gypi
index f6463b743d06e4341a39204855fa4bf393a52595..1500d882a1c1dd957bfb5a4683bf159fcb5cff37 100644
--- a/build/isolate.gypi
+++ b/build/isolate.gypi
@@ -79,13 +79,20 @@
'<(DEPTH)/tools/swarm_client/isolate.py',
'<(test_isolation_mode)',
'--outdir', '<(test_isolation_outdir)',
- '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
+ # Have a space after <(PRODUCT_DIR) or visual studio will
+ # escape the argument wrappping " with the \ and merge it into
+ # the following arguments.
+ '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
'--variable', 'OS', '<(OS)',
'--variable', 'chromeos', '<(chromeos)',
'--result', '<@(_outputs)',
'--isolate', '<(RULE_INPUT_PATH)',
],
}],
+ ['test_isolation_fail_on_missing == 0', {
+ 'action': ['--ignore_broken_items'],
+ },
+ ],
],
'msvs_cygwin_shell': 0,
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698