Issue 12771010: Add a macro for querying the byte order of SkPMColor.

Issue 12771010: Add a macro for querying the byte order of SkPMColor. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
epoger, reed1

CC:
skia-review_googlegroups.com, Ken Russell (switch to Gerrit)

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add a macro for querying the byte order of SkPMColor. R=reed@google.com Committed: http://code.google.com/p/skia/source/detail?r=8219

Patch Set 5 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	include/core/SkPostConfig.h	View	1 2 3	1 chunk	+22 lines, -0 lines	0 comments	Download
		include/gpu/GrTypes.h	View	1 2 3 4	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

epoger

https://codereview.chromium.org/12771010/diff/3003/include/core/SkPostConfig.h File include/core/SkPostConfig.h (right): https://codereview.chromium.org/12771010/diff/3003/include/core/SkPostConfig.h#newcode192 include/core/SkPostConfig.h:192: * #if SK_PM_BYTE_ORDER_IS(B, G, R, A) Clever!!! Very nice.

7 years, 9 months ago (2013-03-11 17:26:32 UTC) #2

reed1

name nit: SK_PMCOLOR_BYTE_ORDER? please add even a simple comment describing what we mean by byte-order ...

7 years, 9 months ago (2013-03-11 17:34:28 UTC) #3

bsalomon

On 2013/03/11 17:34:28, reed1 wrote: > name nit: SK_PMCOLOR_BYTE_ORDER? Done. > > please add even ...

7 years, 9 months ago (2013-03-11 17:46:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/12771010/4003

7 years, 9 months ago (2013-03-19 14:16:27 UTC) #6

Message was sent while issue was closed.

Change committed as 8219

Expand Messages | Collapse Messages