Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12770011: Remove a few chrome dependencies of c/b/webdata (Closed)

Created:
7 years, 9 months ago by kaiwang
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, Jói, Cait (Slow)
Visibility:
Public.

Description

Remove a few chrome dependencies of c/b/webdata chrome/browser/profiles/profile* chrome/common/chrome_paths.h chrome/common/chrome_constants.h COLLABORATOR=joi@chromium.org COLLABORATOR=caitkp@chromium.org BUG=181277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190139

Patch Set 1 #

Patch Set 2 : Remove a DEPS line #

Patch Set 3 : rebase #

Patch Set 4 : rebase again #

Patch Set 5 : Fix win compiling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/webdata/DEPS View 1 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/webdata/autofill_table_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/token_service_table_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/web_apps_table_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/web_database_migration_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/browser/webdata/webdata_constants.h View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
A + chrome/browser/webdata/webdata_constants.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/delete_chrome_history_test.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kaiwang
dhollowa: please review c/b/webdata ben: please review the rest Thanks!
7 years, 9 months ago (2013-03-21 21:58:08 UTC) #1
dhollowa
lgtm
7 years, 9 months ago (2013-03-21 22:07:03 UTC) #2
Ben Goodger (Google)
lgtm
7 years, 9 months ago (2013-03-22 00:17:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12770011/9001
7 years, 9 months ago (2013-03-22 01:28:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12770011/9001
7 years, 9 months ago (2013-03-22 18:41:06 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
7 years, 9 months ago (2013-03-22 20:06:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12770011/32001
7 years, 9 months ago (2013-03-22 20:09:43 UTC) #7
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
7 years, 9 months ago (2013-03-23 00:05:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12770011/47002
7 years, 9 months ago (2013-03-23 00:07:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12770011/47002
7 years, 9 months ago (2013-03-23 15:28:41 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-24 00:38:42 UTC) #11
Message was sent while issue was closed. 
Change committed as 190139

Powered by Google App Engine
This is Rietveld 408576698