client/internal/logdog/butler/bundler/doc.go - Issue 1276923003: logdog: Add bundler library.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: client/internal/logdog/butler/bundler/doc.go

Issue 1276923003: logdog: Add bundler library. (Closed) Base URL: https://github.com/luci/luci-go@logdog-review-streamserver

Patch Set: More documentation, simplified "bundlerStream" struct. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« client/internal/logdog/butler/bundler/bundler_impl.go ('K') | « client/internal/logdog/butler/bundler/bundler_test.go ('k') | client/internal/logdog/butler/bundler/sizer_fast.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Package bundler exports the Bundler interface and its implementation, as well

	6 // as supporting interfaces.

	7 //

	8 // A Bundler is responsible for efficiently buffering and clustering LogDog

	9 // Butler protobufs together for output. It primarily focused on two protobufs:
	tandrii(chromium) 2015/08/11 18:31:05 nit: It is primarily... nit: It is primarily... dnj (Google) 2015/08/12 03:20:09 Done. Show quoted text On 2015/08/11 18:31:05, tandrii(chromium) wrote: > nit: It is primarily... Done. dnj 2015/09/02 01:58:14 Done. Show quoted text On 2015/08/11 18:31:05, tandrii(chromium) wrote: > nit: It is primarily... Done.
	10 // - The ButlerLogBundle_Entry, which represents a series of logs and

	11 // metadata belongining to a single stream.
	tandrii(chromium) 2015/08/11 18:31:05 s/belongining/belonging s/belongining/belonging dnj (Google) 2015/08/12 03:20:09 Done. Show quoted text On 2015/08/11 18:31:05, tandrii(chromium) wrote: > s/belongining/belonging Done. dnj 2015/09/02 01:58:14 Done. Show quoted text On 2015/08/11 18:31:05, tandrii(chromium) wrote: > s/belongining/belonging Done.
	12 // - The LogEntry, which is a single chunk of unqualified log data.

	13 //

	14 // These protobufs comprise log data, and are grouped together for export in

	15 // a ButlerLogBundle protobuf.

	16 //

	17 // A ButlerLogBundle_Entry will be exported if it matches ANY of the following

	18 // conditions:

	19 // - It has attached log data.

	20 // - It has terminal information.

	21 //

	22 // Since LogDog outputs can be size-constrained, the Bundler tracks the expected

	23 // aggregate buffered protobuf size and, on export, breaks the buffered

	24 // protobufs into bundles along a size threshold boundary.

	25 package bundler

OLD	NEW