Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 12769024: History: Fix console errors on Android, and add some iOS ifdefs. (Closed)

Created:
7 years, 9 months ago by Patrick Dubroy
Modified:
7 years, 9 months ago
Reviewers:
Joao da Silva, Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

History: Fix console errors on Android, and add some iOS ifdefs. Fix runtime JavaScript errors on chrome://history that are caused by some missing resources on Android. Also add some iOS ifdefs to match the Android ones. BUG=None TEST=Open chrome://history on Android, and verify that there are no console errors on the adb debug output. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190483

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/browser/ui/webui/history_ui.cc View 6 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Patrick Dubroy
Joao, please take a look.
7 years, 9 months ago (2013-03-25 11:53:19 UTC) #1
Joao da Silva
lgtm
7 years, 9 months ago (2013-03-25 13:05:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/12769024/6001
7 years, 9 months ago (2013-03-25 15:51:36 UTC) #3
commit-bot: I haz the power
Presubmit check for 12769024-6001 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-25 15:51:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/12769024/6001
7 years, 9 months ago (2013-03-25 16:02:44 UTC) #5
Patrick Dubroy
+estade for OWNERS rubber stamp.
7 years, 9 months ago (2013-03-25 16:43:49 UTC) #6
Patrick Dubroy
Next in line: dbeam!
7 years, 9 months ago (2013-03-25 21:04:59 UTC) #7
Dan Beam
lgtm
7 years, 9 months ago (2013-03-25 21:07:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/12769024/6001
7 years, 9 months ago (2013-03-25 21:20:40 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 21:24:28 UTC) #10
Message was sent while issue was closed.
Change committed as 190483

Powered by Google App Engine
This is Rietveld 408576698