Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 12769009: Pass list of printers to chrome using file. (Closed)

Created:
7 years, 9 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 9 months ago
Reviewers:
mpcomplete, gene, Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Pass list of printers to chrome using file. To setup windows service we need to provide list of printers availible for user different that current. We don't want to impersonate chrome thead or run Chrome as different users. Setup utility will collect printers itself and path list to chrome to display UI. BUG=143234 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188677

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -25 lines) Patch
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc View 1 2 3 3 chunks +7 lines, -24 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 1 2 3 3 chunks +33 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 9 months ago (2013-03-15 20:38:03 UTC) #1
gene
https://codereview.chromium.org/12769009/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/12769009/diff/1/chrome/common/chrome_switches.cc#newcode182 chrome/common/chrome_switches.cc:182: const char kCloudPrintAddPrinters[] = "cloud-print-add-printers"; let's use different name, ...
7 years, 9 months ago (2013-03-16 00:29:05 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/12769009/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/12769009/diff/1/chrome/common/chrome_switches.cc#newcode182 chrome/common/chrome_switches.cc:182: const char kCloudPrintAddPrinters[] = "cloud-print-add-printers"; On 2013/03/16 00:29:05, gene ...
7 years, 9 months ago (2013-03-16 00:36:37 UTC) #3
gene
lgtm
7 years, 9 months ago (2013-03-16 00:45:19 UTC) #4
Vitaly Buka (NO REVIEWS)
7 years, 9 months ago (2013-03-16 00:59:15 UTC) #5
Matt Perry
rubber-stamp LGTM
7 years, 9 months ago (2013-03-16 01:11:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12769009/8004
7 years, 9 months ago (2013-03-16 01:30:34 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-16 03:18:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12769009/31001
7 years, 9 months ago (2013-03-16 06:53:20 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=109769
7 years, 9 months ago (2013-03-16 09:28:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12769009/31001
7 years, 9 months ago (2013-03-17 08:48:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12769009/45001
7 years, 9 months ago (2013-03-18 03:06:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12769009/45001
7 years, 9 months ago (2013-03-18 05:15:19 UTC) #13
commit-bot: I haz the power
7 years, 9 months ago (2013-03-18 05:55:21 UTC) #14
Message was sent while issue was closed.
Change committed as 188677

Powered by Google App Engine
This is Rietveld 408576698