Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 12769002: chromeos: Merge DriveDirectory::child_fils_ and child_directories_ into one variable, children_ (Closed)

Created:
7 years, 9 months ago by hashimoto
Modified:
7 years, 9 months ago
Reviewers:
hidehiko, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Merge DriveDirectory::child_files_ and child_directories_ into one variable, children_ BUG=147299 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187291

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -68 lines) Patch
M chrome/browser/chromeos/drive/drive_files.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_files.cc View 5 chunks +44 lines, -66 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
Simplifying DriveDirectory as preparation for DriveDirectory/DriveDirectoryProto removal.
7 years, 9 months ago (2013-03-11 10:56:47 UTC) #1
kinaba
lgtm
7 years, 9 months ago (2013-03-11 11:14:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/12769002/2001
7 years, 9 months ago (2013-03-11 11:21:47 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 13:50:36 UTC) #4
Message was sent while issue was closed.
Change committed as 187291

Powered by Google App Engine
This is Rietveld 408576698