Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 12766002: Updated drag-and-drop assets. (Closed)

Created:
7 years, 9 months ago by mtomasz
Modified:
7 years, 9 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Updated drag-and-drop assets. This patch updates icons for dragging, especially used in Files.app. TEST=Enter Files.app, drag and drop. BUG=137982 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187635

Patch Set 1 #

Patch Set 2 : Fixed hot points. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
M ash/resources/default_100_percent/cros/pointers/copy.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_100_percent/cros/pointers/nodrop.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/cros/pointers/copy.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/cros/pointers/nodrop.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/wm/image_cursors.cc View 1 1 chunk +3 lines, -3 lines 2 comments Download

Messages

Total messages: 16 (0 generated)
mtomasz
@oshima: PTAL.
7 years, 9 months ago (2013-03-11 06:58:36 UTC) #1
oshima
do they have the same hot point?
7 years, 9 months ago (2013-03-11 10:29:57 UTC) #2
mtomasz
On 2013/03/11 10:29:57, oshima wrote: > do they have the same hot point? What do ...
7 years, 9 months ago (2013-03-11 10:45:35 UTC) #3
oshima
Each pointer image has its own point that is used to identify where it is ...
7 years, 9 months ago (2013-03-11 11:03:41 UTC) #4
mtomasz
Fixed the hot points. However, I am confused about the comment in the image_cursors.cc. Are ...
7 years, 9 months ago (2013-03-11 13:31:44 UTC) #5
oshima
We still want to move this into png file. It was just put on hold. ...
7 years, 9 months ago (2013-03-11 16:34:43 UTC) #6
mtomasz
https://codereview.chromium.org/12766002/diff/9001/ash/wm/image_cursors.cc File ash/wm/image_cursors.cc (right): https://codereview.chromium.org/12766002/diff/9001/ash/wm/image_cursors.cc#newcode37 ash/wm/image_cursors.cc:37: {ui::kCursorNotAllowed, IDR_AURA_CURSOR_NO_DROP, {9, 9}, {18, 18}}, On 2013/03/11 16:34:43, ...
7 years, 9 months ago (2013-03-12 01:19:17 UTC) #7
oshima
ah i see. Thank you for clarification. lgtm.
7 years, 9 months ago (2013-03-12 01:27:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12766002/9001
7 years, 9 months ago (2013-03-12 02:03:39 UTC) #9
commit-bot: I haz the power
Presubmit check for 12766002-9001 failed and returned exit status 1. INFO:root:Found 5 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-12 02:03:43 UTC) #10
mtomasz
@sky: I need you OWNERS lgtm. Already reviewed by @oshima.
7 years, 9 months ago (2013-03-12 09:51:05 UTC) #11
sky
LGTM
7 years, 9 months ago (2013-03-12 14:32:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12766002/9001
7 years, 9 months ago (2013-03-12 14:42:08 UTC) #13
commit-bot: I haz the power
Change committed as 187635
7 years, 9 months ago (2013-03-12 20:09:34 UTC) #14
mtomasz
On 2013/03/12 20:09:34, I haz the power (commit-bot) wrote: > Change committed as 187635 Nah, ...
7 years, 9 months ago (2013-03-15 08:11:15 UTC) #15
oshima
7 years, 9 months ago (2013-03-15 11:07:28 UTC) #16
Message was sent while issue was closed.
On 2013/03/15 08:11:15, mtomasz wrote:
> On 2013/03/12 20:09:34, I haz the power (commit-bot) wrote:
> > Change committed as 187635
> 
> Nah, again the assets were not copied. @oshima: Do you have an idea, why the
> assets has not been commited?

CQ can't commit binary files. Please commit them manually.

Powered by Google App Engine
This is Rietveld 408576698