Make service name for sandboxed process configurable so that client can use different set of sandbo…

Make service name for sandboxed process configurable so that client can use different set of sandboxed process

In order to have separate renderer process we need have logic to set service process name

BUG=181470
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188330

[Jungshik Jang, 2013-03-14 15:12:43]

Warm reminder for review.

[Yaron, 2013-03-14 17:22:56]

Your message said "Warm reminder". This is the first I"ve seen it.. note you
have to "Publish + Mail" after uploading a CL to request a review

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java
(right):

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java:56:
private final String mServiceClassName;
Same here, use a class

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
(right):

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:65:
public static void setServiceClassName(String serviceClassName) {
This should take a class object which is safer than taking a raw string. Also
rename, setServiceClass. You should also be able to assert that it inherits from
SandboxedProcessService, right?

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:66:
mServiceClassName = serviceClassName;
Should we assert that we haven't already initiated a connection with the old
classname?

The point here is to set the class before initiating any renderer process
connections, right?

[jayjang, 2013-03-15 00:38:45]

Hi Yaron.

Thanks for your comment and please take another look.
I'm very sorry for rude review request. 
In fact, this is my first chromium cl and I thought system already sent "review
request" email as perforce does in google3. 
I'm sorry again if you feel uncomfortable.

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java
(right):

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java:56:
private final String mServiceClassName;
On 2013/03/14 17:22:56, Yaron wrote:
> Same here, use a class

Thanks for the comment. 
Changed into Class.

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
(right):

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:65:
public static void setServiceClassName(String serviceClassName) {
On 2013/03/14 17:22:56, Yaron wrote:
> This should take a class object which is safer than taking a raw string. Also
> rename, setServiceClass. You should also be able to assert that it inherits
from
> SandboxedProcessService, right?

thanks for good suggestion.
I changed type to Class<? extends SandboxedProcess>.

https://codereview.chromium.org/12764020/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:66:
mServiceClassName = serviceClassName;
On 2013/03/14 17:22:56, Yaron wrote:
> Should we assert that we haven't already initiated a connection with the old
> classname?
> 
> The point here is to set the class before initiating any renderer process
> connections, right?

Thanks for the comment. Your suggestion is much safer. 
I added new boolean variable, "mConnectionAllocated" for this.

[Yaron, 2013-03-15 01:16:47]

lgtm

Oh, no problem at all and I'm sorry if I came off harsh. I wasn't upset, I was
just confused. Glad we're on the same page.

[commit-bot: I haz the power, 2013-03-15 07:01:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jayjang@chromium.org/12764020/11001

[commit-bot: I haz the power, 2013-03-15 10:56:02]

Change committed as 188330

[Jungshik Jang, 2013-03-16 06:54:48]

On 2013/03/15 10:56:02, I haz the power (commit-bot) wrote:
> Change committed as 188330

Thanks for quick review.