sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart - Issue 12764005: Get rid of old code for union/intersection in HType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

Issue 12764005: Get rid of old code for union/intersection in HType. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart ('k') | sdk/lib/_internal/compiler/implementation/types/type_mask.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart b/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

index cc8a75a46c324bc2d9bebac67b6f9164de1c93d0..36e356e0abcbc942579311cd09888a613b871c49 100644

--- a/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

+++ b/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

@@ -334,11 +334,9 @@ class SimpleTypesInferrer extends TypesInferrer {

}

void initializeTypes() {

- // TODO(ngeoffray): Is that the right type?

- Backend backend = compiler.backend;

- nullType = new TypeMask.exact(

- backend.nullImplementation.computeType(compiler));

+ nullType = new TypeMask.empty();

+ Backend backend = compiler.backend;

intType = new TypeMask.nonNullExact(

rawTypeOf(backend.intImplementation));

doubleType = new TypeMask.nonNullExact(

@@ -663,10 +661,6 @@ class SimpleTypesInferrer extends TypesInferrer {

return secondType;

} else if (isDynamicType(firstType)) {

return firstType;

- } else if (firstType == nullType) {

- return secondType.nullable();

- } else if (secondType == nullType) {

- return firstType.nullable();

} else {

TypeMask union = firstType.union(secondType, compiler);

return union == null ? giveUpType : union;