sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 12764005: Get rid of old code for union/intersection in HType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 12764005: Get rid of old code for union/intersection in HType. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

index 6b10c17afffd1c8b9093c70485fbe5f992036f26..e64279de92e6400c978f2c107db0f1cb428c3814 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

@@ -1624,7 +1624,6 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

if (target != null) {

// If we know we're calling a specific method, register that

// method only.

- assert(selector.mask != null);

world.registerDynamicInvocationOf(target, selector);

} else {

SourceString name = node.selector.name;

@@ -1739,8 +1738,7 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

visitFieldSet(HFieldSet node) {

Element element = node.element;

String name = _fieldPropertyName(element);

- DartType type = node.receiver.instructionType.computeType(compiler);

- if (type != null && !identical(type.kind, TypeKind.MALFORMED_TYPE)) {

+ if (!node.receiver.instructionType.isUnknown()) {

// Field setters in the generative constructor body are handled in a

// step "SsaConstructionFieldTypes" in the ssa optimizer.

if (!work.element.isGenerativeConstructorBody()) {