Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 12761002: Fixed multiple undo in the Files.app's image editor. (Closed)

Created:
7 years, 9 months ago by mtomasz
Modified:
7 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fixed multiple undo in the Files.app's image editor. Before, the multiple undo was malfunctioning, however single undo worked correctly. This is because, first undo is a special case. This patch fixes multiple undo operations which uses base image. TEST=Open the image editor, try to rotate several times, then undo several times. Try also redo. BUG=181483 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187261

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/js/image_editor/commands.js View 1 5 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtomasz
@yoshiki: PTAL.
7 years, 9 months ago (2013-03-11 05:17:45 UTC) #1
yoshiki
lgtm with nit. https://codereview.chromium.org/12761002/diff/1/chrome/browser/resources/file_manager/js/image_editor/commands.js File chrome/browser/resources/file_manager/js/image_editor/commands.js (right): https://codereview.chromium.org/12761002/diff/1/chrome/browser/resources/file_manager/js/image_editor/commands.js#newcode191 chrome/browser/resources/file_manager/js/image_editor/commands.js:191: console.log('TRYING, WITH: ' + this.previousImage_.width); nit: ...
7 years, 9 months ago (2013-03-11 05:21:59 UTC) #2
mtomasz
https://codereview.chromium.org/12761002/diff/1/chrome/browser/resources/file_manager/js/image_editor/commands.js File chrome/browser/resources/file_manager/js/image_editor/commands.js (right): https://codereview.chromium.org/12761002/diff/1/chrome/browser/resources/file_manager/js/image_editor/commands.js#newcode191 chrome/browser/resources/file_manager/js/image_editor/commands.js:191: console.log('TRYING, WITH: ' + this.previousImage_.width); On 2013/03/11 05:21:59, yoshiki ...
7 years, 9 months ago (2013-03-11 05:44:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12761002/5001
7 years, 9 months ago (2013-03-11 05:45:09 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 09:10:37 UTC) #5
Message was sent while issue was closed.
Change committed as 187261

Powered by Google App Engine
This is Rietveld 408576698