Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12760012: Rename EventExecutor to InputInjector. (Closed)

Created:
7 years, 9 months ago by Wez
Modified:
7 years, 9 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, sail+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, Lambros
Visibility:
Public.

Description

Rename EventExecutor to InputInjector. This is part of general naming clean-up under remoting/ and will help keep lambroslambrou@ happy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190163

Patch Set 1 #

Total comments: 4

Patch Set 2 : Replace some missed occurrences and remove unused include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -1850 lines) Patch
M remoting/host/basic_desktop_environment.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/basic_desktop_environment.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host_context.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/client_session.h View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/client_session.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 16 chunks +30 lines, -30 lines 0 comments Download
M remoting/host/clipboard_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_environment.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/desktop_session_agent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/desktop_session_agent.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M remoting/host/desktop_session_proxy.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 3 chunks +4 lines, -4 lines 0 comments Download
D remoting/host/event_executor.h View 1 chunk +0 lines, -37 lines 0 comments Download
D remoting/host/event_executor_linux.cc View 1 chunk +0 lines, -507 lines 0 comments Download
D remoting/host/event_executor_mac.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D remoting/host/event_executor_win.cc View 1 chunk +0 lines, -319 lines 0 comments Download
M remoting/host/host_mock_objects.h View 5 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + remoting/host/input_injector.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + remoting/host/input_injector_linux.cc View 16 chunks +37 lines, -37 lines 0 comments Download
A + remoting/host/input_injector_mac.cc View 11 chunks +23 lines, -23 lines 0 comments Download
A + remoting/host/input_injector_win.cc View 13 chunks +26 lines, -26 lines 0 comments Download
M remoting/host/ipc_desktop_environment.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 18 chunks +62 lines, -62 lines 0 comments Download
D remoting/host/ipc_event_executor.h View 1 chunk +0 lines, -45 lines 0 comments Download
D remoting/host/ipc_event_executor.cc View 1 chunk +0 lines, -37 lines 0 comments Download
A + remoting/host/ipc_input_injector.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + remoting/host/ipc_input_injector.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M remoting/host/me2me_desktop_environment.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/win/session_desktop_environment.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/session_desktop_environment.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
D remoting/host/win/session_event_executor.h View 1 chunk +0 lines, -56 lines 0 comments Download
D remoting/host/win/session_event_executor.cc View 1 chunk +0 lines, -224 lines 0 comments Download
A + remoting/host/win/session_input_injector.h View 3 chunks +12 lines, -12 lines 0 comments Download
A + remoting/host/win/session_input_injector.cc View 10 chunks +22 lines, -22 lines 0 comments Download
M remoting/remoting.gyp View 1 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Wez
PTAL Follow-up CLs will get rid of InputInjector by moving Clipboard out of it, then ...
7 years, 9 months ago (2013-03-22 18:28:40 UTC) #1
alexeypa (please no reviews)
lgtm https://chromiumcodereview.appspot.com/12760012/diff/1/remoting/host/client_session_unittest.cc File remoting/host/client_session_unittest.cc (right): https://chromiumcodereview.appspot.com/12760012/diff/1/remoting/host/client_session_unittest.cc#newcode74 remoting/host/client_session_unittest.cc:74: // Returns |event_executor_| created and initialized by SetUp(), ...
7 years, 9 months ago (2013-03-22 21:19:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12760012/6001
7 years, 9 months ago (2013-03-23 00:06:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12760012/6001
7 years, 9 months ago (2013-03-23 15:27:20 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-24 03:42:45 UTC) #5
Message was sent while issue was closed. 
Change committed as 190163

Powered by Google App Engine
This is Rietveld 408576698