Add android buildbot support for exe tests

Add android buildbot support for exe tests

Add breakpad_unittests and sandbox_linux_unittests
to experimental test suites.

BUG=170530, 169416
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187768

[Isaac (away), 2013-03-11 18:54:16]

yaron: Do you know what's wrong w/ breakpad_unittests?
jln: Ditto: linux_sandbox_unittests.

[jln (very slow on Chromium), 2013-03-11 19:57:19]

On 2013/03/11 18:54:16, Isaac wrote:
> yaron: Do you know what's wrong w/ breakpad_unittests?
> jln: Ditto: linux_sandbox_unittests.

It's working here. Both seem to exhibit the same failure and it doesn't look
like a failing test. Something related to "Strip" ?

I've just tried locally:

1. ninja -C out/Debug -j 500 sandbox_linux_unittests
2. build/android/run_tests.py --exe -s sandbox_linux_unittests

It's working here.

[jln (very slow on Chromium), 2013-03-11 20:08:08]

As discussed in person, it just looks like the test is not being built.

Can you add:

diff --git a/build/all_android.gyp b/build/all_android.gyp
index ff0d227..ebe84b7 100644
--- a/build/all_android.gyp
+++ b/build/all_android.gyp
@@ -100,6 +100,7 @@
             '../media/media.gyp:media_unittests_apk',
             '../net/net.gyp:net_unittests_apk',
             '../sandbox/sandbox.gyp:sandbox_linux_jni_unittests_apk',
+            '../sandbox/sandbox.gyp:sandbox_linux_unittests',
             '../sql/sql.gyp:sql_unittests_apk',
             '../sync/sync.gyp:sync_unit_tests_apk',
             '../ui/ui.gyp:ui_unittests_apk',

[Yaron, 2013-03-11 20:40:41]

We should be building breakpad_unittests. I see this error:
WARNING:root:Failed obtaining tests from 0149CD261200C004 with exception:
'STRIP'

Could it be that it's relying on the $STRIP environment variable which isn't set
on the testers. Do the tester bots source envsetup?

[Isaac (away), 2013-03-11 22:14:51]

On 2013/03/11 20:40:41, Yaron wrote:
> We should be building breakpad_unittests. I see this error:
> WARNING:root:Failed obtaining tests from 0149CD261200C004 with exception:
> 'STRIP'
> 
> Could it be that it's relying on the $STRIP environment variable which isn't
set
> on the testers. Do the tester bots source envsetup?

We source envsetup for bash commands but not for tests sent to run_test.py.  I
will look into adding the strip variable to constants.

[frankf, 2013-03-12 03:13:15]

https://codereview.chromium.org/12758002/diff/19001/build/android/pylib/gtest...
File build/android/pylib/gtest/gtest_config.py (right):

https://codereview.chromium.org/12758002/diff/19001/build/android/pylib/gtest...
build/android/pylib/gtest/gtest_config.py:11: False: [],
Let's just use 'apk'/'exe' as keys since it's self-explanatory.

[Isaac (away), 2013-03-12 03:19:43]

Julien: looks like sandbox_linux_unittests is already getting built; do you
still want me to add your gyp change?

https://codereview.chromium.org/12758002/diff/19001/build/android/pylib/gtest...
File build/android/pylib/gtest/gtest_config.py (right):

https://codereview.chromium.org/12758002/diff/19001/build/android/pylib/gtest...
build/android/pylib/gtest/gtest_config.py:11: False: [],
On 2013/03/12 03:13:15, frankf wrote:
> Let's just use 'apk'/'exe' as keys since it's self-explanatory.

sgtm.  I'm going to switch this to namedtuples.

[Isaac (away), 2013-03-12 05:49:42]

please take another look.  I think this is cleaner that my earlier approach of
using dicts.

[frankf, 2013-03-12 17:46:31]

lgtm w/ nits for pylib after trybots going green.

https://chromiumcodereview.appspot.com/12758002/diff/12002/build/android/pyli...
File build/android/pylib/gtest/dispatch.py (right):

https://chromiumcodereview.appspot.com/12758002/diff/12002/build/android/pyli...
build/android/pylib/gtest/dispatch.py:42: def GetQualifiedSuite(suite):
nit: let's move this to the top of the outer method.

https://chromiumcodereview.appspot.com/12758002/diff/12002/build/android/pyli...
File build/android/pylib/gtest/gtest_config.py (right):

https://chromiumcodereview.appspot.com/12758002/diff/12002/build/android/pyli...
build/android/pylib/gtest/gtest_config.py:8: 
2 blank lines between top level here and below.

[Isaac (away), 2013-03-13 03:24:30]

CQing w/ NOTRY

https://chromiumcodereview.appspot.com/12758002/diff/12002/build/android/pyli...
File build/android/pylib/gtest/dispatch.py (right):

https://chromiumcodereview.appspot.com/12758002/diff/12002/build/android/pyli...
build/android/pylib/gtest/dispatch.py:42: def GetQualifiedSuite(suite):
On 2013/03/12 17:46:31, frankf wrote:
> nit: let's move this to the top of the outer method.

Done.

[commit-bot: I haz the power, 2013-03-13 03:27:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/12758002/54001

[commit-bot: I haz the power, 2013-03-13 03:27:12]

Presubmit check for 12758002-54001 failed and returned exit status 1.

INFO:root:Found 4 file(s).

INFO:PRESUBMIT:Running pylint on 4 files
Error running bb_run_bot with id="try-tests" + .
build/android/buildbot/buildbot_functions.sh
++ JOBS=4
+ bb_baseline_setup /b/commit-queue/workdir/chromium '--factory-properties={}'
'--build-properties={}' '--slave-properties={}'
+ SRC_ROOT=/b/commit-queue/workdir/chromium
+ shift
+ cd /b/commit-queue/workdir/chromium
+ echo '@@@BUILD_STEP Environment setup@@@'
+ bb_parse_args '--factory-properties={}' '--build-properties={}'
'--slave-properties={}'
+ [[ -n --factory-properties={} ]]
+ case "$1" in
++ echo '--factory-properties={}'
++ sed 's/^[^=]*=//'
+ FACTORY_PROPERTIES='{}'
++ bb_get_json_prop '{}' target
++ local 'JSON={}'
++ local PROP=target
++ python -c 'import json; print json.loads('\''{}'\'').get('\''target'\'',
'\'''\'')'
+ BUILDTYPE=
+ shift
+ [[ -n --build-properties={} ]]
+ case "$1" in
++ echo '--build-properties={}'
++ sed 's/^[^=]*=//'
+ BUILD_PROPERTIES='{}'
+ shift
+ [[ -n --slave-properties={} ]]
+ case "$1" in
++ echo '--slave-properties={}'
++ sed 's/^[^=]*=//'
+ SLAVE_PROPERTIES='{}'
+ shift
+ [[ -n '' ]]
+ export GYP_GENERATORS=ninja
+ GYP_GENERATORS=ninja
+ export GOMA_DIR=/b/build/goma
+ GOMA_DIR=/b/build/goma
+ . build/android/envsetup.sh
+++ dirname build/android/envsetup.sh
++ . build/android/envsetup_functions.sh
++ export ANDROID_SDK_BUILD=1
++ ANDROID_SDK_BUILD=1
++ process_options '--factory-properties={}' '--build-properties={}'
'--slave-properties={}'
+++ uname -s
+++ sed -e 's/Linux/linux/;s/Darwin/mac/'
++ host_os=linux
++ try_32bit_host_build=
++ [[ -n --factory-properties={} ]]
++ case "$1" in
++ echo 'Unknown option: --factory-properties={}'
++ shift
++ [[ -n --build-properties={} ]]
++ case "$1" in
++ echo 'Unknown option: --build-properties={}'
++ shift
++ [[ -n --slave-properties={} ]]
++ case "$1" in
++ echo 'Unknown option: --slave-properties={}'
++ shift
++ [[ -n '' ]]
++ TARGET_ARCH=arm
++ [[ '' -eq 1 ]]
++ [[ 1 -ne 1 ]]
+++ uname -m
++ host_arch=x86_64
++ case "${host_arch}" in
++ case "${host_os}" in
++ toolchain_dir=linux-x86_64
++++ dirname build/android/envsetup.sh
+++ readlink -f build/android/../../
++ CURRENT_DIR=/b/commit-queue/workdir/chromium
++ [[ -z '' ]]
++ export CHROME_SRC=/b/commit-queue/workdir/chromium
++ CHROME_SRC=/b/commit-queue/workdir/chromium
++ [[ '' == \/\b\/\c\o\m\m\i\t\-\q\u\e\u\e\/\w\o\r\k\d\i\r\/\c\h\r\o\m\i\u\m ]]
++ export ANDROID_SDK_VERSION=17
++ ANDROID_SDK_VERSION=17
++ [[ 1 -eq 1 ]]
++ [[ -z arm ]]
++ sdk_build_init
++ [[ -z '' ]]
++ export
ANDROID_NDK_ROOT=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk/
++
ANDROID_NDK_ROOT=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk/
++ local sdk_suffix=platforms/android-17
++ [[ -z '' ]]
++ export
ANDROID_SDK_ROOT=/b/commit-queue/workdir/chromium/third_party/android_tools/sdk/
++
ANDROID_SDK_ROOT=/b/commit-queue/workdir/chromium/third_party/android_tools/sdk/
++ unset ANDROID_BUILD_TOP
++ export TARGET_PRODUCT=trygon
++ TARGET_PRODUCT=trygon
++ unset ANDROID_TOOLCHAIN
++ common_vars_defines
++ case "${TARGET_ARCH}" in
++ toolchain_arch=arm-linux-androideabi
++ toolchain_version=4.6
++ gcc_version=46
+++ basename
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6
++ toolchain_target=arm-linux-androideabi-4.6
++
toolchain_path=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/
++ export
ANDROID_TOOLCHAIN=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/
++
ANDROID_TOOLCHAIN=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/
++ common_check_toolchain
++ [[ ! -d
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/
]]
++ echo 'Can not find Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.'
Can not find Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
++ echo 'The NDK version might be wrong.'
The NDK version might be wrong.
++ return 1

Error running bb_run_bot with id="main-tests" + .
build/android/buildbot/buildbot_functions.sh
++ JOBS=4
+ bb_baseline_setup /b/commit-queue/workdir/chromium '--factory-properties={}'
'--build-properties={}' '--slave-properties={}'
+ SRC_ROOT=/b/commit-queue/workdir/chromium
+ shift
+ cd /b/commit-queue/workdir/chromium
+ echo '@@@BUILD_STEP Environment setup@@@'
+ bb_parse_args '--factory-properties={}' '--build-properties={}'
'--slave-properties={}'
+ [[ -n --factory-properties={} ]]
+ case "$1" in
++ echo '--factory-properties={}'
++ sed 's/^[^=]*=//'
+ FACTORY_PROPERTIES='{}'
++ bb_get_json_prop '{}' target
++ local 'JSON={}'
++ local PROP=target
++ python -c 'import json; print json.loads('\''{}'\'').get('\''target'\'',
'\'''\'')'
+ BUILDTYPE=
+ shift
+ [[ -n --build-properties={} ]]
+ case "$1" in
++ echo '--build-properties={}'
++ sed 's/^[^=]*=//'
+ BUILD_PROPERTIES='{}'
+ shift
+ [[ -n --slave-properties={} ]]
+ case "$1" in
++ echo '--slave-properties={}'
++ sed 's/^[^=]*=//'
+ SLAVE_PROPERTIES='{}'
+ shift
+ [[ -n '' ]]
+ export GYP_GENERATORS=ninja
+ GYP_GENERATORS=ninja
+ export GOMA_DIR=/b/build/goma
+ GOMA_DIR=/b/build/goma
+ . build/android/envsetup.sh
+++ dirname build/android/envsetup.sh
++ . build/android/envsetup_functions.sh
++ export ANDROID_SDK_BUILD=1
++ ANDROID_SDK_BUILD=1
++ process_options '--factory-properties={}' '--build-properties={}'
'--slave-properties={}'
+++ uname -s
+++ sed -e 's/Linux/linux/;s/Darwin/mac/'
++ host_os=linux
++ try_32bit_host_build=
++ [[ -n --factory-properties={} ]]
++ case "$1" in
++ echo 'Unknown option: --factory-properties={}'
++ shift
++ [[ -n --build-properties={} ]]
++ case "$1" in
++ echo 'Unknown option: --build-properties={}'
++ shift
++ [[ -n --slave-properties={} ]]
++ case "$1" in
++ echo 'Unknown option: --slave-properties={}'
++ shift
++ [[ -n '' ]]
++ TARGET_ARCH=arm
++ [[ '' -eq 1 ]]
++ [[ 1 -ne 1 ]]
+++ uname -m
++ host_arch=x86_64
++ case "${host_arch}" in
++ case "${host_os}" in
++ toolchain_dir=linux-x86_64
++++ dirname build/android/envsetup.sh
+++ readlink -f build/android/../../
++ CURRENT_DIR=/b/commit-queue/workdir/chromium
++ [[ -z '' ]]
++ export CHROME_SRC=/b/commit-queue/workdir/chromium
++ CHROME_SRC=/b/commit-queue/workdir/chromium
++ [[ '' == \/\b\/\c\o\m\m\i\t\-\q\u\e\u\e\/\w\o\r\k\d\i\r\/\c\h\r\o\m\i\u\m ]]
++ export ANDROID_SDK_VERSION=17
++ ANDROID_SDK_VERSION=17
++ [[ 1 -eq 1 ]]
++ [[ -z arm ]]
++ sdk_build_init
++ [[ -z '' ]]
++ export
ANDROID_NDK_ROOT=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk/
++
ANDROID_NDK_ROOT=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk/
++ local sdk_suffix=platforms/android-17
++ [[ -z '' ]]
++ export
ANDROID_SDK_ROOT=/b/commit-queue/workdir/chromium/third_party/android_tools/sdk/
++
ANDROID_SDK_ROOT=/b/commit-queue/workdir/chromium/third_party/android_tools/sdk/
++ unset ANDROID_BUILD_TOP
++ export TARGET_PRODUCT=trygon
++ TARGET_PRODUCT=trygon
++ unset ANDROID_TOOLCHAIN
++ common_vars_defines
++ case "${TARGET_ARCH}" in
++ toolchain_arch=arm-linux-androideabi
++ toolchain_version=4.6
++ gcc_version=46
+++ basename
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6
++ toolchain_target=arm-linux-androideabi-4.6
++
toolchain_path=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/
++ export
ANDROID_TOOLCHAIN=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/
++
ANDROID_TOOLCHAIN=/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/
++ common_check_toolchain
++ [[ ! -d
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/
]]
++ echo 'Can not find Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.'
Can not find Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
++ echo 'The NDK version might be wrong.'
The NDK version might be wrong.
++ return 1

Error running bb_run_bot with id="fyi-tests" + .
build/android/buildbot/buildbot_functions.sh
++ JOBS=4
+ bb_baseline_setup /b/commit-queue/workdir/chromium '--factory-properties={}'
'--build-properties={}' '--slave-properties={}'
+ SRC_ROOT=/b/commit-queue/workdir/chromium
+ shift
+ cd /b/commit-queue/workdir/chromium
+ echo '@@@BUILD_STEP Environment setup@@@'
+ bb_parse_args '--factory-properties={}' '--build-properties={}'
'--slave-properties={}'
+ [[ -n --factory-properties={} ]]
+ case "$1" in
++ echo '--factory-properties={}'
++ sed 's/^[^=]*=//'
+ FACTORY_PROPERTIES='{}'
++ bb_get_json_prop '{}' target
++ local 'JSON={}'
++ local PROP=target
++ python -c 'import json; print json.loads('\''{}'\'').get('\''target'\'',
'\'''\'')'
+ BUILDTYPE=
+ shift
+ [[ -n --build-properties={} ]]
+ case "$1" in
++ echo '--build-properties={}'
++ sed 's/^[^=]*=//'
+ BUILD_PROPERTIES='{}'
+ shift
+ [[ -n --slave-properties={} ]]
+ case "$1" in
++ echo '--slave-properties={}'
++ sed 's/^[^=]*=//'
+ SLAVE_PROPERTIES='{}'
+ shift
+ [[ -n '' ]]
+ export GYP_GENERATORS=ninja
+ GYP_GENERATORS=ninja
+ export GOMA_DIR=/b/build/goma
+ GOMA_DIR=/b/build/goma
+ . build/android/envsetup.sh
+++ dirname build/androi…
(message too large)

[commit-bot: I haz the power, 2013-03-13 03:43:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/12758002/62001

[commit-bot: I haz the power, 2013-03-13 03:43:18]

Presubmit check for 12758002-62001 failed and returned exit status 1.

INFO:root:Found 4 file(s).

INFO:PRESUBMIT:Running pylint on 4 files
Error running bb_run_bot with id="try-tests" Can not find Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="main-tests" Can not find Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="fyi-tests" Can not find Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="webkit-latest-webkit-tests" Can not find
Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="asan-tests" Can not find Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="try-fyi-tests" Can not find Android toolchain
in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="webkit-latest-contentshell" Can not find
Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="webkit-latest-tests" Can not find Android
toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="chromedriver-fyi-tests-dbg" Can not find
Android toolchain in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Error running bb_run_bot with id="perf-tests-rel" Can not find Android toolchain
in
/b/commit-queue/workdir/chromium/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/.
The NDK version might be wrong.

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/build/android/PRESUBMIT.py
Running pylint on 4 files.
Running
/b/commit-queue/workdir/chromium/build/android/buildbot/tests/bb_run_bot_test.py

** Presubmit ERRORS **
/b/commit-queue/workdir/chromium/build/android/buildbot/tests/bb_run_bot_test.py
failed!
Command
/b/commit-queue/workdir/chromium/build/android/buildbot/tests/bb_run_bot_test.py
--verbose returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium/build/android

Presubmit checks took 3.9s to calculate.

[commit-bot: I haz the power, 2013-03-13 03:52:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/12758002/65001

[commit-bot: I haz the power, 2013-03-13 04:09:28]

Change committed as 187768