Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 12754010: Move immersive_mode_controller into c/b/ui/views/frame (Closed)

Created:
7 years, 9 months ago by James Cook
Modified:
7 years, 9 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Move immersive_mode_controller into c/b/ui/views/frame BUG=none TEST=compiles R=pkotwicz@chromium.org TBR=sky@chromium.org for simple file move Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -867 lines) Patch
M chrome/browser/ui/views/ash/tab_scrubber.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/frame/immersive_mode_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/frame/immersive_mode_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/frame/immersive_mode_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/top_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/immersive_mode_controller.h View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/browser/ui/views/immersive_mode_controller.cc View 1 chunk +0 lines, -422 lines 0 comments Download
D chrome/browser/ui/views/immersive_mode_controller_browsertest.cc View 1 chunk +0 lines, -270 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Peter, PTAL
7 years, 9 months ago (2013-03-14 21:32:29 UTC) #1
pkotwicz
LGTM
7 years, 9 months ago (2013-03-14 23:04:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/12754010/1
7 years, 9 months ago (2013-03-14 23:18:31 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 08:18:28 UTC) #4
Message was sent while issue was closed.
Change committed as 188298

Powered by Google App Engine
This is Rietveld 408576698