Issue 12751002: Support optional function expression parameters in dart2js.

Issue 12751002: Support optional function expression parameters in dart2js. (Closed)

Created:
7 years, 9 months ago by aam-me

Modified:
7 years, 9 months ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support optional function expression parameters in dart2js. BUG=dartbug.com/4597 Committed: https://code.google.com/p/dart/source/detail?r=19832

Patch Set 2 : Added spaces around ternary operator. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree_validator.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

aam-me

Hi, Please take a look when you have a chance. Hope it is as simple ...

7 years, 9 months ago (2013-03-10 17:00:08 UTC) #1

ahe

LGTM! https://codereview.chromium.org/12751002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/12751002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3564 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3564: SourceString source = node.selector.asIdentifier() != null? http://www.dartlang.org/articles/style-guide/#do-use-spaces-around-binary-and-ternary-operators-after-commas-and-not-around-unary-operators

7 years, 9 months ago (2013-03-11 07:34:28 UTC) #2

aam-me

Thank you for the reviews! https://chromiumcodereview.appspot.com/12751002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://chromiumcodereview.appspot.com/12751002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3564 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3564: SourceString source = node.selector.asIdentifier() ...

7 years, 9 months ago (2013-03-12 00:00:38 UTC) #4

aam-me

7 years, 9 months ago (2013-03-12 00:41:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19832 (presubmit successful).

Expand Messages | Collapse Messages