Issue 12747010: Remove BalloonCollectionImplAsh.

Issue 12747010: Remove BalloonCollectionImplAsh. (Closed)

Created:
7 years, 9 months ago by Jun Mukai

Modified:
7 years, 8 months ago

Reviewers:
stevenjb, Dmitry Titov, sky

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org, stevenjb, miket_OOO

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove BalloonCollectionImplAsh. Nowadays MessageCenterNotificationManager is used and these deleted files haven't been used at all for weeks. R=dimich@chromium.org TEST=compilation succeeds Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192895

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -545 lines)			Patch
D	chrome/browser/ui/views/ash/balloon_collection_impl_ash.h	View		1 chunk	+0 lines, -76 lines	0 comments	Download
D	chrome/browser/ui/views/ash/balloon_collection_impl_ash.cc	View		1 chunk	+0 lines, -170 lines	0 comments	Download
D	chrome/browser/ui/views/ash/balloon_view_ash.h	View		1 chunk	+0 lines, -57 lines	0 comments	Download
D	chrome/browser/ui/views/ash/balloon_view_ash.cc	View	1 2	1 chunk	+0 lines, -236 lines	0 comments	Download
M	chrome/browser/ui/views/notifications/balloon_collection_views.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 12 (0 generated)

Jun Mukai

On 2013/04/05 22:53:15, Dmitry Titov wrote: > looks like balloon_view_ash.cc is not included... thanks for ...

7 years, 8 months ago (2013-04-06 00:55:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12747010/6001

7 years, 8 months ago (2013-04-08 17:30:03 UTC) #9

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=115963

7 years, 8 months ago (2013-04-08 19:24:41 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12747010/6001

7 years, 8 months ago (2013-04-08 20:43:19 UTC) #11

Message was sent while issue was closed.

Change committed as 192895