|
|
Created:
5 years, 4 months ago by mvendramini_hp Modified:
5 years, 3 months ago Reviewers:
Vitaly Buka (NO REVIEWS) CC:
chromium-reviews, csaavedra Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixing URL on footer when print previewing selection only
After selecting some text in any webpage, opening up print
preview and then checking Selection only, the URL on the
print preview area's footer is no longer the original URL,
but an internal representation instead.
BUG=516778
R=vitalybuka@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/b4ddd31384403463c36bb63ba95c10290cf9e128
Patch Set 1 #
Messages
Total messages: 19 (4 generated)
Does this still works? https://code.google.com/p/chromium/issues/detail?id=263710
On 2015/08/05 17:59:48, Vitaly Buka wrote: > Does this still works? > > https://code.google.com/p/chromium/issues/detail?id=263710 Yes, I've tested with that step-by-step procedure (create three pages and call window.print() etc) and there were no regressions.
The CQ bit was checked by vitalybuka@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274653003/1
The CQ bit was unchecked by commit-bot@chromium.org
The author mvendramini@hp.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
On 2015/08/07 17:08:34, commit-bot: I haz the power wrote: > The author mailto:mvendramini@hp.com has not signed Google Contributor License > Agreement. Please visit https://cla.developers.google.com to sign and manage > CLA. HP CLA issue is being resolved. I guess it's not urgent and we can wait.
On 2015/08/07 17:10:10, Vitaly Buka wrote: > On 2015/08/07 17:08:34, commit-bot: I haz the power wrote: > > The author mailto:mvendramini@hp.com has not signed Google Contributor License > > Agreement. Please visit https://cla.developers.google.com to sign and manage > > CLA. > > HP CLA issue is being resolved. > I guess it's not urgent and we can wait. Acknowledged. Any action required for the time being?
The CQ bit was checked by vitalybuka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274653003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: The author mvendramini@hp.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
On 2015/08/19 18:56:18, commit-bot: I haz the power wrote: > Dry run: The author mailto:mvendramini@hp.com has not signed Google Contributor License > Agreement. Please visit https://cla.developers.google.com to sign and manage > CLA. No action required. We can wait couple of weeks.
On 2015/08/19 18:57:29, Vitaly Buka wrote: > On 2015/08/19 18:56:18, commit-bot: I haz the power wrote: > > Dry run: The author mailto:mvendramini@hp.com has not signed Google > Contributor License > > Agreement. Please visit https://cla.developers.google.com to sign and manage > > CLA. > > No action required. We can wait couple of weeks. Hello, I think the CLA will take a while longer. Can we proceed?
On 2015/08/31 19:26:17, mvendramini wrote: > On 2015/08/19 18:57:29, Vitaly Buka wrote: > > On 2015/08/19 18:56:18, commit-bot: I haz the power wrote: > > > Dry run: The author mailto:mvendramini@hp.com has not signed Google > > Contributor License > > > Agreement. Please visit https://cla.developers.google.com to sign and manage > > > CLA. > > > > No action required. We can wait couple of weeks. > > Hello, I think the CLA will take a while longer. Can we proceed? I need your "First Last" names for the patch description.
On 2015/09/02 21:08:56, Vitaly Buka wrote: > On 2015/08/31 19:26:17, mvendramini wrote: > > On 2015/08/19 18:57:29, Vitaly Buka wrote: > > > On 2015/08/19 18:56:18, commit-bot: I haz the power wrote: > > > > Dry run: The author mailto:mvendramini@hp.com has not signed Google > > > Contributor License > > > > Agreement. Please visit https://cla.developers.google.com to sign and > manage > > > > CLA. > > > > > > No action required. We can wait couple of weeks. > > > > Hello, I think the CLA will take a while longer. Can we proceed? > > I need your "First Last" names for the patch description. Not sure how to do that, should I just post here? Mateus Vendramini.
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as b4ddd31384403463c36bb63ba95c10290cf9e128 (presubmit successful). |