Completely disable use of bind() with pseudo-random port selection on Windows.

net/quic/quic_stream_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_stream_factory.h"
 
 #include <set>
 
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 493 matching lines @@
     const HostPortProxyPair& host_port_proxy_pair,
     bool is_https,
     CertVerifier* cert_verifier,
     const AddressList& address_list,
     const BoundNetLog& net_log,
     QuicClientSession** session) {
   QuicGuid guid = random_generator_->RandUint64();
   IPEndPoint addr = *address_list.begin();
   scoped_refptr<PortSuggester> port_suggester =
       new PortSuggester(host_port_proxy_pair.first, port_seed_);
+  DatagramSocket::BindType bind_type = DatagramSocket::RANDOM_BIND;
+#if defined(OS_WIN)
+  // TODO(jar)bug=329255 Provide better implementation to avoid pop-up warning.
+  bind_type = DatagramSocket::DEFAULT_BIND;

[Ryan Hamilton, 2014/01/08 22:21:52]

nit: i wonder if it would more symmetrical to do:

#if defined(OS_WIN)
  // TODO(jar)bug=329255 Provide better implementation to avoid pop-up warning.
  DatagramSocket::BindType bind_type = DatagramSocket::DEFAULT_BIND;
#else
  DatagramSocket::BindType bind_type = DatagramSocket::RANDOM_BIND;
#endif

Clearly this is not terribly important, but doing an assignment in the ifdef
just looked a bit odd.

+#endif
   scoped_ptr<DatagramClientSocket> socket(
       client_socket_factory_->CreateDatagramClientSocket(
-          DatagramSocket::RANDOM_BIND,
+          bind_type,
           base::Bind(&PortSuggester::SuggestPort, port_suggester),
           net_log.net_log(), net_log.source()));
   int rv = socket->Connect(addr);
   if (rv != OK)
     return rv;
   UMA_HISTOGRAM_COUNTS("Net.QuicEphemeralPortsSuggested",
                        port_suggester->call_count());
+#if defined(OS_WIN)
+  // TODO(jar)bug=329255 Provide better implementation to avoid pop-up warning.
+  DCHECK_EQ(0u, port_suggester->call_count());
+#else
   DCHECK_LE(1u, port_suggester->call_count());
+#endif

[wtc, 2014/01/08 22:36:05]

I would just do

// TODO(jar)bug=329255 Provide better implementation to avoid pop-up warning.
#if !defined(OS_WIN)
  UMA_HISTOGRAM_COUNTS("Net.QuicEphemeralPortsSuggested",
                       port_suggester->call_count());
  DCHECK_LE(1u, port_suggester->call_count());
#endif

 
   // We should adaptively set this buffer size, but for now, we'll use a size
   // that is more than large enough for a full receive window, and yet
   // does not consume "too much" memory.  If we see bursty packet loss, we may
   // revisit this setting and test for its impact.
   const int32 kSocketBufferSize(TcpReceiver::kReceiveWindowTCP);
   socket->SetReceiveBufferSize(kSocketBufferSize);
   // Set a buffer large enough to contain the initial CWND's worth of packet
   // to work around the problem with CHLO packets being sent out with the
   // wrong encryption level, when the send buffer is full.
@@ skipping 97 matching lines @@
   // Copy the CachedState for the canonical server from canonical_crypto_config
   // as the initial CachedState for the server_hostname in crypto_config.
   crypto_config->InitializeFrom(server_hostname,
                                 canonical_host_port_proxy_pair.first.host(),
                                 canonical_crypto_config);
   // Update canonical version to point at the "most recent" crypto_config.
   canonical_hostname_to_origin_map_[canonical_host_port] = host_port_proxy_pair;
 }
 
 }  // namespace net