Issue 12740009: Always accept strace logs to have the last line corrupted.

Issue 12740009: Always accept strace logs to have the last line corrupted. (Closed)

Created:
7 years, 9 months ago by M-A Ruel

Modified:
7 years, 9 months ago

Reviewers:
csharp

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/tools/swarm_client.git@master

Visibility:
Public.

More Reviews

Description

Always accept strace logs to have the last line corrupted. Consider the log corrupted only if something follows a corrupted line. A log ending with a corrupted line only means the process was terminated abruptly. Improve the test to ensure the internal state of the parser is known. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=189063

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -54 lines)			Patch
	M	tests/trace_inputs_test.py	View		17 chunks	+63 lines, -34 lines	0 comments	Download
	M	trace_inputs.py	View		4 chunks	+7 lines, -20 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12740009/1

7 years, 9 months ago (2013-03-19 18:43:48 UTC) #3

commit-bot: I haz the power

Presubmit check for 12740009-1 failed and returned exit status 1. INFO:root:Found 2 file(s). INFO:PRESUBMIT:Running pylint ...

7 years, 9 months ago (2013-03-19 18:44:28 UTC) #4

Presubmit check for 12740009-1 failed and returned exit status 1.

INFO:root:Found 2 file(s).
INFO:PRESUBMIT:Running pylint on 63 files
test_large (__main__.IsolateServerTest) ... ok
test_missing (__main__.IsolateServerTest) ... ok
test_present (__main__.IsolateServerTest) ... ok
test_process_items (__main__.IsolateServerTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.103s

OK
test_load_isolated_bad (__main__.RunIsolatedTest) ... ok
test_load_isolated_empty (__main__.RunIsolatedTest) ... ok
test_load_isolated_good (__main__.RunIsolatedTest) ... ok
test_load_isolated_os_bad (__main__.RunIsolatedTest) ... ok
test_load_isolated_os_only (__main__.RunIsolatedTest) ... ok
test_remote_no_errors (__main__.RunIsolatedTest) ... ok
test_remote_with_errors (__main__.RunIsolatedTest) ... ok
test_zip_header_error (__main__.RunIsolatedTest) ... ok
testCountKeyInData (__main__.UrlHelperTest) ... ok
testUrlOpenFailure (__main__.UrlHelperTest) ... ok
testUrlOpenGETSuccess (__main__.UrlHelperTest) ... ok
testUrlOpenHTTPErrorNoRetry (__main__.UrlHelperTest) ... ok
testUrlOpenHTTPErrorRetry404 (__main__.UrlHelperTest) ... ok
testUrlOpenHTTPErrorWithRetry (__main__.UrlHelperTest) ... ok
testUrlOpenPOSTSuccess (__main__.UrlHelperTest) ... ok
testUrlOpenSuccessAfterFailure (__main__.UrlHelperTest) ... ok

----------------------------------------------------------------------
Ran 16 tests in 0.025s

OK
A basic linux manifest test to ensure that windows specific values ... ok
test_basic_manifest (__main__.ManifestTest) ... ok
test_process_manifest_success (__main__.ManifestTest) ... ok
test_process_manifest_success_zip_already_uploaded (__main__.ManifestTest) ...
ok

----------------------------------------------------------------------
Ran 4 tests in 0.004s

OK
Zipping up files...
Zipping completed, time elapsed: 0.000013
Zip file not on server, starting uploading.
Sending test requests to swarm
Zipping up files...
Zipping completed, time elapsed: 0.000009
Zip file already on server, no need to reupload.
Sending test requests to swarm
test_simple (__main__.TraceTestCases) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.628s

OK
test_archive_empty_file (__main__.IsolateServerArchiveSmokeTest) ... ok
test_archive_small_file (__main__.IsolateServerArchiveSmokeTest) ... FAIL

======================================================================
FAIL: test_archive_small_file (__main__.IsolateServerArchiveSmokeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/isolateserver_archive_smoke_test.py",
line 80, in test_archive_small_file
    self._archive_given_files(['small_file.txt'])
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/isolateserver_archive_smoke_test.py",
line 74, in _archive_given_files
    'File %s was missing from the server' % files[i])
AssertionError: File small_file.txt was missing from the server

----------------------------------------------------------------------
Ran 2 tests in 5.834s

FAILED (failures=1)
Warning: only eventually consistent
Warning: only eventually consistent
Warning: only eventually consistent
test_shards (__main__.ListTestCasesTest) ... ok
testRunSome (__main__.RunTestCases) ... ok
testStatsInfinite (__main__.RunTestCases) ... ok
test_calc_cluster_default (__main__.RunTestCases) ... ok
test_call (__main__.RunTestCases) ... ok
test_call_eol (__main__.RunTestCases) ... ok
test_call_timed_out_kill (__main__.RunTestCases) ... ok
test_call_timed_out_kill_eol (__main__.RunTestCases) ... ok
test_call_timeout_no_kill (__main__.RunTestCases) ... ok
test_call_timeout_no_kill_eol (__main__.RunTestCases) ... ok
test_gtest_filter (__main__.RunTestCases) ... INFO:root:Found 2 test cases in
/usr/bin/python
/b/commit-queue/workdir/tools/swarm_client/tests/gtest_fake/gtest_fake_pass.py
ok
test_process_output_crash_cr (__main__.RunTestCases) ... ok
test_process_output_crash_garbage_ok (__main__.RunTestCases) ... ok
test_process_output_crash_ok (__main__.RunTestCases) ... ok
test_process_output_crashes (__main__.RunTestCases) ... ok
test_process_output_fail_1 (__main__.RunTestCases) ... ok
test_process_output_garbage (__main__.RunTestCases) ... ok
test_process_output_missing (__main__.RunTestCases) ... ok
test_process_output_ok (__main__.RunTestCases) ... ok
test_gen_xml (__main__.RunTestCasesTmp) ... ok
test_xml (__main__.RunTestCasesTmp) ...
DEBUG:root:/tmp/run_test_casesSuZo1T/a.xml existed
DEBUG:root:/tmp/run_test_casesSuZo1T/a_0.xml existed
DEBUG:root:/tmp/run_test_casesSuZo1T/a_1.xml existed
ok
test_xml_default (__main__.RunTestCasesTmp) ... ok
test_exception (__main__.WorkerPoolTest) ... DEBUG:root:ThreadPool(8, 8, 0)
DEBUG:root:Looping in join() with 1 unfinished tasks
DEBUG:root:Calling all_tasks_done.wait() at 1363718648.93
WARNING:root:Caught exception: 0
INFO:root:  File "/b/commit-queue/workdir/tools/swarm_client/run_isolated.py",
line 499, in _run
    out = func(*args, **kwargs)
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/run_test_cases_test.py", line
483, in mapper
    raise FearsomeException(value)

DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:0 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:6 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:5 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:4 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:3 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.93
DEBUG:root:0 unfinished tasks
ok
test_normal (__main__.WorkerPoolTest) ... DEBUG:root:ThreadPool(8, 8, 0)
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:0 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:0 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:3 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.94
DEBUG:root:3 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:0 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:3 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:3 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:0 unfinished tasks
DEBUG:root:Looping in join() with 2 unfinished tasks
DEBUG:root:Calling all_tasks_done.wait() at 1363718648.95
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:0 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:6 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:5 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:4 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:4 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:3 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.95
DEBUG:root:2 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.96
DEBUG:root:1 unfinished tasks
DEBUG:root:all_tasks_done.notify_all() at 1363718648.96
DEBUG:root:0 unfinished tasks
ok

----------------------------------------------------------------------
Ran 24 tests in 2.152s

OK
test_100_variables (__main__.Tests) ... ok
test_multiple_nontrivial_regions (__main__.Tests) ... ok
test_partitions (__main__.Tests) ... ok
test_short_expression_finder_failure (__main__.Tests) ... ok
test_simple (__main__.Tests) ..…
(message too large)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12740009/1

7 years, 9 months ago (2013-03-19 18:46:30 UTC) #5

Message was sent while issue was closed.

Change committed as 189063

Expand Messages | Collapse Messages