QUIC/Crypto - Enabled curve25519 key exchange code.

QUIC/Crypto - Enabled curve25519 key exchange code.

R=wtc@chromium.org

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187161

[ramant (doing other things), 2013-03-09 00:33:16]

Hi Wan-Teh,
  Enabled Curve25519 code. Could you please take a look?

thanks
raman

[wtc, 2013-03-09 01:23:27]

Patch set 1 LGTM.

https://chromiumcodereview.appspot.com/12740002/diff/1/net/quic/crypto/curve2...
File net/quic/crypto/curve25519_key_exchange_test.cc (right):

https://chromiumcodereview.appspot.com/12740002/diff/1/net/quic/crypto/curve2...
net/quic/crypto/curve25519_key_exchange_test.cc:7: #include <string.h>

I think you meant to include the C++ header <string>.

[ramant (doing other things), 2013-03-09 01:38:27]

curve25519_key_exchange.h is including <string> and we are not including
<string> if the header file includes it. Thus didn't include <string> *.cc
files.

Thanks for catching it.

https://chromiumcodereview.appspot.com/12740002/diff/1/net/quic/crypto/curve2...
File net/quic/crypto/curve25519_key_exchange_test.cc (right):

https://chromiumcodereview.appspot.com/12740002/diff/1/net/quic/crypto/curve2...
net/quic/crypto/curve25519_key_exchange_test.cc:7: #include <string.h>
On 2013/03/09 01:23:28, wtc wrote:
> 
> I think you meant to include the C++ header <string>.

Deleted the include of <string.h>. My mistake.
Done.

[wtc, 2013-03-09 02:05:16]

Patch set 2 LGTM.

[commit-bot: I haz the power, 2013-03-09 02:43:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/12740002/3002

[commit-bot: I haz the power, 2013-03-09 14:58:56]

Change committed as 187161