Issue 12738005: Launch mosaic view only if most of the selected files are images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12738005: Launch mosaic view only if most of the selected files are images. (Closed)

Created:
7 years, 9 months ago by mtomasz

Modified:
7 years, 9 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Launch mosaic view only if most of the selected files are images. After enabling mosaic view on every volume, a problem with videos showing up in a mosaic view appeared. This patch fixes this problem by showing a slide view instead of mosaic view if the selected files are mostly videos. TEST=Select multiple videos and click on Open. Slide view should appear. When selecting multiple images, mosaic view should appear. BUG=180453 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187275

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	chrome/browser/resources/file_manager/js/photo/gallery.js	View		2 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12738005/1

7 years, 9 months ago (2013-03-11 09:39:05 UTC) #3

Message was sent while issue was closed.

Change committed as 187275

Expand Messages | Collapse Messages