Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2642)

Unified Diff: chrome/browser/resources/feedback.js

Issue 12737006: Allow feedback form to be shown in an App Launcher feedback mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Woops Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback.js
diff --git a/chrome/browser/resources/feedback.js b/chrome/browser/resources/feedback.js
index b17cc1981254dccc24bfdbad80e8a0928425a572..5c0d8818995fd938640f09978e961a33e1fdcc4e 100644
--- a/chrome/browser/resources/feedback.js
+++ b/chrome/browser/resources/feedback.js
@@ -95,7 +95,19 @@ function addScreenshot(divId, screenshot) {
}
/**
- * Disables screenshots completely.
+ * Shows the app launcher version of the feedback form.
+ */
+function showLauncherFeedback() {
+ $('page-url').hidden = true;
+ $('screenshot-row').hidden = true;
+ $('title').hidden = true;
+ $('description').hidden = true;
+ $('launcher-title').hidden = false;
+ $('launcher-description').hidden = false;
+}
+
+/**
+ * Enables screenshots.
*/
function enableScreenshots() {
if (forceDisableScreenshots)
@@ -399,7 +411,9 @@ function setupDialogDefaults(defaults) {
$('user-email-checkbox').checked = defaults.emailCheckboxDefault;
// Are screenshots disabled?
tapted 2013/03/15 05:06:03 maybe update this comment (or remove it, since it'
benwells 2013/03/15 05:54:34 I've just removed it, doesn't feel that necessary.
- if (!defaults.disableScreenshots)
+ if (defaults.launcherFeedback)
+ showLauncherFeedback();
+ else if (!defaults.disableScreenshots)
enableScreenshots();
if (defaults.useSaved) {

Powered by Google App Engine
This is Rietveld 408576698