Issue 12735007: Set the ant keystore properties earlier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12735007: Set the ant keystore properties earlier (Closed)

Created:
7 years, 9 months ago by cjhopman

Modified:
7 years, 9 months ago

Reviewers:
Tom Hudson, Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Set the ant keystore properties earlier apk-build.xml sets the has.keystore property before the point where we were setting the properties that it bases has.keystore on. This caused Release builds to be built incorrectly (i.e. the build didn't sign them). BUG=184532 NOTRY=true TBR=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187598

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -11 lines)			Patch
	M	build/android/ant/apk-build.xml	View		2 chunks	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12735007/1

7 years, 9 months ago (2013-03-12 16:35:49 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages