Provision Android devices after the 'device_status_check' step.

build/android/buildbot/bb_device_steps.py

Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index 4bc095d809d5c3914e100f103b940f57443d42eb..e60cdedd5588f6aca3f35e94fdfa1bb38f2587ae 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -264,6 +264,15 @@ def MainTestWrapper(options):
   buildbot_report.PrintNamedStep('device_status_check')
   RunCmd(['build/android/device_status_check.py'], flunk_on_failure=False)
 
+  # Provision devices
+  buildername = options.build_properties.get('buildername', '')
+  if buildername == 'Android GN (stats)':

[Isaac (away), 2013/03/19 00:05:22]

I'd prefer to filter by waterfall instead of by builder.  Also --
provision_devices reboots each phone, so we should not also run RebootDevices
(line 260/261) if we are provisioning.

[Siva Chandra, 2013/03/19 00:45:05]

This particular provisioning script does not reboot the phones.

[Isaac (away), 2013/03/19 22:28:18]

How about we use options.experimental for this, which will enable it on the FYI
waterfall? 
The issues with line 269 are:
1) We really, really try to avoid looking at builder name.
2) Logic for test options should be in bb_run_bot.py, not here.

+    buildbot_report.PrintNamedStep('provision_devices')
+    adb_reboot = (CHROME_SRC +
+                  '/out/%s/adb_reboot' % options.factory_properties['target'])
+    cmd = ['build/android/provision_devices.py', '-a', '%s' % adb_reboot]
+    RunCmd(cmd, flunk_on_failure=False)

[Isaac (away), 2013/03/19 00:05:22]

Let's not set 'flunk_on_failure=False'.  I'd prefer to avoid this paradigm
unless we specifically find we need it.

+
   if options.install:
     test_obj = INSTRUMENTATION_TESTS[options.install]
     InstallApk(options, test_obj, print_step=True)