Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 12731006: Enable browser tests for ChromeOS. (Closed)

Created:
7 years, 9 months ago by calvinlo
Modified:
7 years, 9 months ago
Reviewers:
kinuko, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Enable browser tests for ChromeOS. BUG=160693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188995

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
calvinlo
This passes now on linux_chromeos trybot. It's failing on cros_* but the failures don't seem ...
7 years, 9 months ago (2013-03-15 09:34:28 UTC) #1
tzik
lgtm
7 years, 9 months ago (2013-03-18 02:15:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/12731006/4001
7 years, 9 months ago (2013-03-18 03:09:13 UTC) #3
commit-bot: I haz the power
Presubmit check for 12731006-4001 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-18 03:09:18 UTC) #4
calvinlo
Oops, sorry Kinuko, I actually need your LGTM for this one since you're the only ...
7 years, 9 months ago (2013-03-18 03:56:00 UTC) #5
kinuko
lgtm
7 years, 9 months ago (2013-03-18 04:06:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/12731006/4001
7 years, 9 months ago (2013-03-19 08:42:18 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 11:23:25 UTC) #8
Message was sent while issue was closed.
Change committed as 188995

Powered by Google App Engine
This is Rietveld 408576698