- Use dart:typedata types in the Dart API calls.

runtime/vm/dart_api_message.cc

Index: runtime/vm/dart_api_message.cc
===================================================================
--- runtime/vm/dart_api_message.cc	(revision 19764)
+++ runtime/vm/dart_api_message.cc	(working copy)
@@ -430,7 +430,8 @@
       ::free(utf16);
       return object;
     }
-    case kUint8ArrayCid: {
+    case kTypedDataUint8ArrayCid:
+    case kExternalTypedDataUint8ArrayCid: {

[Anton Muhin, 2013/03/12 08:31:46]

I am not familiar with this part of the system, but apparently external array is
serialized as a pointer to data, not data itself, but apparently again here you
expect all the data back, is it ok?

[Mads Ager (google), 2013/03/12 08:36:17]

This is a bit complicated. The data is not serialized with the code below. It is
serialized in raw_object_snapshot.cc and both internal and external are
serialized the same.

The serialization for external typed arrays below is read by the snapshot reader
in raw_object_snapshot.cc which handles the pointers correctly.

The message reader is running independently of the VM in separate threads in a
thread pool. It writes a snapshot that the VM snapshot reader can read. It reads
a snapshot that the VM snapshot writer has created.

       intptr_t len = ReadSmiValue();
       Dart_CObject* object = AllocateDartCObjectUint8Array(len);
       AddBackRef(object_id, object, kIsDeserialized);
@@ -846,8 +847,9 @@
       // Write out the serialization header value for this object.
       WriteInlinedHeader(object);
       // Write out the class and tags information.
-      WriteIndexedObject(kUint8ArrayCid);
-      WriteIntptrValue(0);
+      WriteIndexedObject(kTypedDataUint8ArrayCid);
+      WriteIntptrValue(RawObject::ClassIdTag::update(
+          kTypedDataUint8ArrayCid, 0));
       uint8_t* bytes = object->value.as_byte_array.values;
       intptr_t len = object->value.as_byte_array.length;
       WriteSmi(len);
@@ -865,8 +867,9 @@
       // Write out serialization header value for this object.
       WriteInlinedHeader(object);
       // Write out the class and tag information.
-      WriteIndexedObject(kExternalUint8ArrayCid);
-      WriteIntptrValue(0);
+      WriteIndexedObject(kExternalTypedDataUint8ArrayCid);
+      WriteIntptrValue(RawObject::ClassIdTag::update(
+          kExternalTypedDataUint8ArrayCid, 0));
       int length = object->value.as_external_byte_array.length;
       uint8_t* data = object->value.as_external_byte_array.data;
       void* peer = object->value.as_external_byte_array.peer;