Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: runtime/bin/file_patch.dart

Issue 12730013: - Use dart:typedata types in the Dart API calls. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/io.dart » ('j') | runtime/lib/typeddata.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file_patch.dart
===================================================================
--- runtime/bin/file_patch.dart (revision 19764)
+++ runtime/bin/file_patch.dart (working copy)
@@ -35,6 +35,6 @@
/* patch */ static _flush(int id) native "File_Flush";
}
-List<int> _makeUint8ListView(List<int> source, int from, int to) {
- return new Uint8List.view(source.asByteArray(), from, to);
+List<int> _makeUint8ListView(List<int> source, int offsetInBytes, int length) {
Ivan Posva 2013/03/12 09:32:02 Don't you want to add the correct type to source?
siva 2013/03/12 10:31:46 Yes, it is an ExternalTypedData of Uint8List, so I
+ return new Uint8List.view(source.buffer, offsetInBytes, length);
}
« no previous file with comments | « no previous file | runtime/bin/io.dart » ('j') | runtime/lib/typeddata.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698