- Use dart:typedata types in the Dart API calls.

runtime/lib/typeddata.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // patch classes for Int8List ..... Float64List and ByteData implementations.
 
 patch class Int8List {
   /* patch */ factory Int8List(int length) {
     return new _Int8Array(length);
   }
@@ skipping 418 matching lines @@
   List toList() {
     return new List.from(this);
   }
 
   Set toSet() {
     return new Set.from(this);
   }
 
   List getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
-    List result = _new(length);
+    List result = _createList(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List from, [int startFrom = 0]) {
     IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
   }
 
   // Method(s) implementing Object interface.
 
@@ skipping 102 matching lines @@
 
   // Method(s) implementing TypedData interface.
 
   int get elementSizeInBytes {
     return Int8List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Int8Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Int8Array _new(int length) native "TypedData_Int8Array_new";
 }
 
 
 class _Uint8Array extends _TypedList implements Uint8List {
   // Factory constructors.
 
   factory _Uint8Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 31 matching lines @@
   Iterator<int> get iterator {
     return new _TypedListIterator<int>(this);
   }
 
 
   // Methods implementing TypedData interface.
   int get elementSizeInBytes {
     return Uint8List.BYTES_PER_ELEMENT;
   }
 
+
   // Internal utility methods.
 
+  _Uint8Array _createList(int length) {
+    return _new(length);
+  }
+

[Ivan Posva, 2013/03/12 09:32:02]

Missing line.

[siva, 2013/03/12 10:31:46]

It seems to have a blank line.

On 2013/03/12 09:32:02, Ivan Posva wrote:

   static _Uint8Array _new(int length) native "TypedData_Uint8Array_new";
 }
 
 
 class _Uint8ClampedArray extends _TypedList implements Uint8ClampedList {
   // Factory constructors.
 
   factory _Uint8ClampedArray(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 35 matching lines @@
 
 
   // Methods implementing TypedData interface.
   int get elementSizeInBytes {
     return Uint8List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Uint8ClampedArray _createList(int length) {
+    return _new(length);
+  }
+

[Ivan Posva, 2013/03/12 09:32:02]

ditto here and more below.

[siva, 2013/03/12 10:31:46]

Seems to have it. The pattern in the file was one blank line between functions
and two when a different interface started.

On 2013/03/12 09:32:02, Ivan Posva wrote:

   static _Uint8ClampedArray _new(int length)
       native "TypedData_Uint8ClampedArray_new";
 }
 
 
 class _Int16Array extends _TypedList implements Int16List {
   // Factory constructors.
 
   factory _Int16Array(int length) {
     if (length < 0) {
@@ skipping 38 matching lines @@
 
   // Method(s) implementing TypedData interface.
 
   int get elementSizeInBytes {
     return Int16List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Int16Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Int16Array _new(int length) native "TypedData_Int16Array_new";
 }
 
 
 class _Uint16Array extends _TypedList implements Uint16List {
   // Factory constructors.
 
   factory _Uint16Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 37 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Uint16List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Uint16Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Uint16Array _new(int length) native "TypedData_Uint16Array_new";
 }
 
 
 class _Int32Array extends _TypedList implements Int32List {
   // Factory constructors.
 
   factory _Int32Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 37 matching lines @@
 
   // Method(s) implementing TypedData interface.
 
   int get elementSizeInBytes {
     return Int32List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Int32Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Int32Array _new(int length) native "TypedData_Int32Array_new";
 }
 
 
 class _Uint32Array extends _TypedList implements Uint32List {
   // Factory constructors.
 
   factory _Uint32Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 37 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Uint32List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Uint32Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Uint32Array _new(int length) native "TypedData_Uint32Array_new";
 }
 
 
 class _Int64Array extends _TypedList implements Int64List {
   // Factory constructors.
 
   factory _Int64Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 37 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Int64List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Int64Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Int64Array _new(int length) native "TypedData_Int64Array_new";
 }
 
 
 class _Uint64Array extends _TypedList implements Uint64List {
   // Factory constructors.
 
   factory _Uint64Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 37 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Uint64List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Uint64Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Uint64Array _new(int length) native "TypedData_Uint64Array_new";
 }
 
 
 class _Float32Array extends _TypedList implements Float32List {
   // Factory constructors.
 
   factory _Float32Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 37 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Float32List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Float32Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Float32Array _new(int length) native "TypedData_Float32Array_new";
 }
 
 
 class _Float64Array extends _TypedList implements Float64List {
   // Factory constructors.
 
   factory _Float64Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 37 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Float64List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  _Float64Array _createList(int length) {
+    return _new(length);
+  }
+
   static _Float64Array _new(int length) native "TypedData_Float64Array_new";
 }
 
 
 class _ExternalInt8Array extends _TypedList implements Int8List {
   // Factory constructors.
 
   factory _ExternalInt8Array(int length) {
     if (length < 0) {
       String message = "$length must be greater than 0";
@@ skipping 27 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Int8List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<int> _createList(int length) {

[Mads Ager (google), 2013/03/12 08:18:03]

List<int> -> Int8List?

Similarly for the ones below?

[siva, 2013/03/12 10:31:46]

Good point. Changed all the return values.

On 2013/03/12 08:18:03, Mads Ager wrote:

+    return new Int8List(length);
+  }
+
   static _ExternalInt8Array _new(int length) native
       "ExternalTypedData_Int8Array_new";
 }
 
 
 class _ExternalUint8Array extends _TypedList implements Uint8List {
   // Factory constructors.
 
   factory _ExternalUint8Array(int length) {
     if (length < 0) {
@@ skipping 19 matching lines @@
       String message = "$index must be in the range [0..$length)";
       throw new RangeError(message);
     }
     _setUint8(index, _toUint8(value));
   }
 
   Iterator<int> get iterator {
     return new _TypedListIterator<int>(this);
   }
 
-

[Ivan Posva, 2013/03/12 09:32:02]

?

[siva, 2013/03/12 10:31:46]

Done.

   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Uint8List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<int> _createList(int length) {
+    return new Uint8List(length);
+  }
+
   static _ExternalUint8Array _new(int length) native
       "ExternalTypedData_Uint8Array_new";
 }
 
 
 class _ExternalUint8ClampedArray extends _TypedList implements Uint8ClampedList {
   // Factory constructors.
 
   factory _ExternalUint8ClampedArray(int length) {
     if (length < 0) {
@@ skipping 29 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Uint8List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<int> _createList(int length) {
+    return new Uint8ClampedList(length);
+  }
+
   static _ExternalUint8ClampedArray _new(int length) native
       "ExternalTypedData_Uint8ClampedArray_new";
 }
 
 
 class _ExternalInt16Array extends _TypedList implements Int16List {
   // Factory constructors.
 
   factory _ExternalInt16Array(int length) {
     if (length < 0) {
@@ skipping 29 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Int16List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<int> _createList(int length) {
+    return new Int16List(length);
+  }
+
   static _ExternalInt16Array _new(int length) native
       "ExternalTypedData_Int16Array_new";
 }
 
 
 class _ExternalUint16Array extends _TypedList implements Uint16List {
   // Factory constructors.
 
   factory _ExternalUint16Array(int length) {
     if (length < 0) {
@@ skipping 29 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Uint16List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<int> _createList(int length) {
+    return new Uint16List(length);
+  }
+
   static _ExternalUint16Array _new(int length) native
       "ExternalTypedData_Uint16Array_new";
 }
 
 
 class _ExternalInt32Array extends _TypedList implements Int32List {
   // Factory constructors.
   
   factory _ExternalInt32Array(int length) {
     if (length < 0) {
@@ skipping 29 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Int32List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<int> _createList(int length) {
+    return new Int32List(length);
+  }
+
   static _ExternalInt32Array _new(int length) native
       "ExternalTypedData_Int32Array_new";
 }
 
 
 class _ExternalUint32Array extends _TypedList implements Uint32List {
   // Factory constructors.
 
   factory _ExternalUint32Array(int length) {
     if (length < 0) {
@@ skipping 29 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Uint32List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<int> _createList(int length) {
+    return new Uint32List(length);
+  }
+
   static _ExternalUint32Array _new(int length) native
       "ExternalTypedData_Uint32Array_new";
 }
 
 
 class _ExternalInt64Array extends _TypedList implements Int64List {
   // Factory constructors.
 
   factory _ExternalInt64Array(int length) {
     if (length < 0) {
@@ skipping 29 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Int64List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<int> _createList(int length) {
+    return new Int64List(length);
+  }
+
   static _ExternalInt64Array _new(int length) native
       "ExternalTypedData_Int64Array_new";
 }
 
 
 class _ExternalUint64Array extends _TypedList implements Uint64List {
   // Factory constructors.
 
   factory _ExternalUint64Array(int length) {
     if (length < 0) {
@@ skipping 22 matching lines @@
     _setUint64(index, _toUint64(value));
   }
 
   Iterator<int> get iterator {
     return new _TypedListIterator<int>(this);
   }
 
 
   // Method(s) implementing the TypedData interface.
 
+  List<int> _createList(int length) {
+    return new Uint64List(length);
+  }
+
   int get elementSizeInBytes {
     return Uint64List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
   static _ExternalUint64Array _new(int length) native
       "ExternalTypedData_Uint64Array_new";
 }
@@ skipping 36 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Float32List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<double> _createList(int length) {
+    return new Float32List(length);
+  }
+
   static _ExternalFloat32Array _new(int length) native
       "ExternalTypedData_Float32Array_new";
 }
 
 
 class _ExternalFloat64Array extends _TypedList implements Float64List {
   // Factory constructors.
 
   factory _ExternalFloat64Array(int length) {
     if (length < 0) {
@@ skipping 29 matching lines @@
 
   // Method(s) implementing the TypedData interface.
 
   int get elementSizeInBytes {
     return Float64List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
+  List<double> _createList(int length) {
+    return new Float64List(length);
+  }
+
   static _ExternalFloat64Array _new(int length) native
       "ExternalTypedData_Float64Array_new";
 }
 
 
 class _TypedListIterator<E> implements Iterator<E> {
   final List<E> _array;
   final int _length;
   int _position;
   E _current;
@@ skipping 14 matching lines @@
     _current = null;
     return false;
   }
 
   E get current => _current;
 }
 
 
 class _TypedListView extends _TypedListBase implements TypedData {
   _TypedListView(ByteBuffer _buffer, int _offset, int _length)
-    : _typeddata = _buffer,  // This assignment is type safe.
+    : super(),

[Anton Muhin, 2013/03/12 08:31:46]

nit: as per style guide, shouldn't super ctor invocation go to the end of the
list?  and do you need to invoke default ctor explicitly at all?

[siva, 2013/03/12 10:31:46]

Removed the explicit invoke of the default ctor, I had added it to debug stuff
and forgot to remove it.

On 2013/03/12 08:31:46, Anton Muhin wrote:

+      _typeddata = _buffer,  // This assignment is type safe.
       offsetInBytes = _offset,
       length = _length {
   }
 
 
   // Method(s) implementing the TypedData interface.
 
   int get lengthInBytes {
     return length * elementSizeInBytes;
   }
 
   ByteBuffer get buffer {
     return _typeddata.buffer;
   }
 
   final TypedData _typeddata;
   final int offsetInBytes;
   final int length;
 }
 
 
 class _Int8ArrayView extends _TypedListView implements Int8List {
   // Constructor.
   _Int8ArrayView(ByteBuffer buffer, [int _offsetInBytes = 0, int _length])
     : super(buffer, _offsetInBytes,
             _defaultIfNull(_length,
                            ((buffer.lengthInBytes - _offsetInBytes) ~/
                             Int8List.BYTES_PER_ELEMENT))) {
     _rangeCheck(buffer.lengthInBytes,
-                offsetInBytes,
-                length * Int8List.BYTES_PER_ELEMENT);
+                _offsetInBytes,
+                _length * Int8List.BYTES_PER_ELEMENT);
   }
 
 
   // Method(s) implementing List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       String message = "$index must be in the range [0..$length)";
       throw new RangeError(message);
     }
@@ skipping 24 matching lines @@
 
 
 class _Uint8ArrayView extends _TypedListView implements Uint8List {
   // Constructor.
   _Uint8ArrayView(ByteBuffer buffer, [int _offsetInBytes = 0, int _length])
     : super(buffer, _offsetInBytes,
             _defaultIfNull(_length,
                            ((buffer.lengthInBytes - _offsetInBytes) ~/
                             Uint8List.BYTES_PER_ELEMENT))) {
     _rangeCheck(buffer.lengthInBytes,
-                offsetInBytes,
-                length * Uint8List.BYTES_PER_ELEMENT);
+                _offsetInBytes,
+                _length * Uint8List.BYTES_PER_ELEMENT);
   }
 
 
   // Method(s) implementing List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       String message = "$index must be in the range [0..$length)";
       throw new RangeError(message);
     }
@@ skipping 604 matching lines @@
   if (start + length > listLength) {
     throw new RangeError.value(start + length);
   }
 }
 
 
 int _defaultIfNull(object, value) {
   if (object == null) {
     return value;
   }
+  return object;
 }