Issue 12729008: Fix isolate.gypi when run with Visual Studio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12729008: Fix isolate.gypi when run with Visual Studio (Closed)

Created:
7 years, 9 months ago by csharp

Modified:
7 years, 9 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix isolate.gypi when run with Visual Studio NOTRY=True BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188181

Patch Set 2 : Removing Tabs #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	build/isolate.gypi	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lovely lgtm with spaces. https://codereview.chromium.org/12729008/diff/1/build/isolate.gypi File build/isolate.gypi (right): https://codereview.chromium.org/12729008/diff/1/build/isolate.gypi#newcode66 build/isolate.gypi:66: # Also have a space ...

7 years, 9 months ago (2013-03-14 19:17:45 UTC) #2

csharp

https://codereview.chromium.org/12729008/diff/1/build/isolate.gypi File build/isolate.gypi (right): https://codereview.chromium.org/12729008/diff/1/build/isolate.gypi#newcode66 build/isolate.gypi:66: # Also have a space after <(PRODUCT_DIR) or visual ...

7 years, 9 months ago (2013-03-14 19:30:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/12729008/1002

7 years, 9 months ago (2013-03-14 19:45:01 UTC) #4

Message was sent while issue was closed.

Change committed as 188181

Expand Messages | Collapse Messages

Issue 12729008: Fix isolate.gypi when run with Visual Studio (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removing Tabs #

Messages