Follow-up fixes to http://crrev.com/12638033.

Follow-up fixes to http://crrev.com/12638033.

1) Fixed message_center_bubble.cc's MessageListView so it propagates
changes related to notification expansion to the MessageCenterView.

2) Miscellanous cleanups in notification_view.cc.

BUG=168939, 168940
R=mukai@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188295

[dharcourt, 2013-03-13 22:47:51]

Hello again.

PTAL when you get a chance. These are follow ups to http://12638033/, with the
most important one being a fix to an updating bug introduced with 1263803. This
is still in preparation of supporting text line limits in notification views.

Thanks!

    - Charles

https://codereview.chromium.org/12726005/diff/1/ui/message_center/views/messa...
File ui/message_center/views/message_center_bubble.cc (right):

https://codereview.chromium.org/12726005/diff/1/ui/message_center/views/messa...
ui/message_center/views/message_center_bubble.cc:326: }
Without this the MessageCenterView never would get notified of the preferred
size change that accompanies a notification expansion, so it wouldn't have a
chance to update the message center. This fixes that.

https://codereview.chromium.org/12726005/diff/1/ui/message_center/views/notif...
File ui/message_center/views/notification_view.cc (right):

https://codereview.chromium.org/12726005/diff/1/ui/message_center/views/notif...
ui/message_center/views/notification_view.cc:67: // ContainerView
///////////////////////////////////////////////////////////////
It's becoming hard to find nested classes in this file. These comments are an
attempt to solve that problem.

https://codereview.chromium.org/12726005/diff/1/ui/message_center/views/notif...
ui/message_center/views/notification_view.cc:150: class ProportionalImageView :
public views::View {
Rather than having 3 lines of comment explaining why ProportionalImageView
shouldn't be treated as an ImageView, it's simpler to simply not have
ProportionalImageView be an ImageView subclass.

https://codereview.chromium.org/12726005/diff/1/ui/message_center/views/notif...
ui/message_center/views/notification_view.cc:192:
draw_bounds.ClampToCenteredSize(draw_size);
Fixed these calculations to work when there are insets, using
ClampToCenteredSize() to cut down on the boilerplate computations.

[Jun Mukai, 2013-03-14 02:31:17]

lgtm

[commit-bot: I haz the power, 2013-03-14 18:30:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/12726005/1

[commit-bot: I haz the power, 2013-03-15 08:17:40]

Change committed as 188295