Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 12720008: Update instance types in grokdump. (Closed)

Created:
7 years, 9 months ago by Toon Verwaest
Modified:
7 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Update instance types in grokdump. Committed: https://code.google.com/p/v8/source/detail?r=13999

Patch Set 1 : #

Patch Set 2 : Also update KNOWN_MAPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -142 lines) Patch
M tools/grokdump.py View 1 2 chunks +143 lines, -142 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 9 months ago (2013-03-19 16:18:20 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 9 months ago (2013-03-20 10:21:24 UTC) #2
Toon Verwaest
7 years, 9 months ago (2013-03-20 10:22:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698