Issue 12720005: Remove outdated widows SDK check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12720005: Remove outdated widows SDK check (Closed)

Created:
7 years, 9 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 9 months ago

Reviewers:

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove outdated widows SDK check This is breaking vs2012 waterfall fyi bots Our codebase has now many things that don't compile with ancient sdks. TBR=scottmg BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188239

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	base/win/win_util.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottmg

7 years, 9 months ago (2013-03-15 01:44:59 UTC) #2

Message was sent while issue was closed.

On 2013/03/15 01:36:21, cpu wrote:
> Committed patchset #1 manually as r188239.

see https://codereview.chromium.org/12465017/

Expand Messages | Collapse Messages