[Android] Remove unused function.

[Android] Remove unused function.

I just removed the last caller of this functoin (downstream). It uses reflection
and is unreliable. Tests shouldn't be written in this manner.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188746

[Yaron, 2013-03-16 01:51:01]

joth: please confirm it's unused in webview.
https://gerrit-int.chromium.org/#/c/33920/ removes it from chrome.

[joth, 2013-03-16 02:55:10]

lgtm

down stream webview test code only uses the public API, so not possible
it's using this



On 15 March 2013 18:51, <yfriedman@chromium.org> wrote:

> Reviewers: joth,
>
> Message:
> joth: please confirm it's unused in webview.
>
https://gerrit-int.chromium.**org/#/c/33920/<https://gerrit-int.chromium.org/...
it from chrome.
>
> Description:
> [Android] Remove unused function.
>
> I just removed the last caller of this functoin (downstream). It uses
> reflection
> and is unreliable. Tests shouldn't be written in this manner.
>
>
> Please review this at
https://codereview.chromium.**org/12717011/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M build/android/findbugs_filter/**findbugs_known_bugs.txt
>   M content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**UiUtils.java
>
>
> Index: build/android/findbugs_filter/**findbugs_known_bugs.txt
> diff --git a/build/android/findbugs_**filter/findbugs_known_bugs.txt
> b/build/android/findbugs_**filter/findbugs_known_bugs.txt
> index 5f5f25954f3e489fb76c7f25758b39**3739406f08..**
> a41f055db4ac3e8868317b64921613**5527ffde78 100644
> --- a/build/android/findbugs_**filter/findbugs_known_bugs.txt
> +++ b/build/android/findbugs_**filter/findbugs_known_bugs.txt
> @@ -57,7 +57,6 @@ M C USELESS_STRING: Invocation of toString on certChain
> in org.chromium.net.X509
>  M D DMI: Hard coded reference to an absolute pathname in
> org.chromium.android_webview.**test.ArchiveTest.**testAutoBadPath()  At
> ArchiveTest.java
>  M D DMI: Hard coded reference to an absolute pathname in
> org.chromium.android_webview.**test.ArchiveTest.**testExplicitBadPath()
>  At ArchiveTest.java
>  M D ICAST: integral division result cast to double or float in
> org.chromium.content.browser.**HandleView.setOrientation(int)  At
> HandleView.java
> -M D REC: Exception is caught when Exception is not thrown in
> org.chromium.content.browser.**test.util.UiUtils.**
> findParentViewForIdAcrossActiv**ities(int)  At UiUtils.java
>  M D SF: Switch statement found in org.chromium.chrome.browser.**
> ChromeBrowserProvider.insert(**Uri, ContentValues) where one case falls
> through to the next case  At ChromeBrowserProvider.java
>  M D SF: Switch statement found in org.chromium.chrome.browser.**
> database.SQLiteCursor.**fillWindow(int, CursorWindow) where default case
> is missing  At SQLiteCursor.java
>  M D SF: Switch statement found in org.chromium.content.browser.**
> ContentSettings$EventHandler$**1.handleMessage(Message) where default
> case is missing  At ContentSettings.java
> Index: content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**UiUtils.java
> diff --git a/content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**UiUtils.java b/content/public/test/android/**
> javatests/src/org/chromium/**content/browser/test/util/**UiUtils.java
> index 0dea234e2dc6cc5344d6cabfa7739e**9f25b3dfa2..**
> 7c51542e84eb1223b5d183f65e98d4**801c3a4480 100644
> --- a/content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**UiUtils.java
> +++ b/content/public/test/android/**javatests/src/org/chromium/**
> content/browser/test/util/**UiUtils.java
> @@ -6,14 +6,12 @@ package org.chromium.content.browser.**test.util;
>
>  import android.app.Activity;
>  import android.app.Instrumentation;
> -import android.view.View;
>
> -import java.lang.reflect.Field;
> +import junit.framework.Assert;
> +
>  import java.util.concurrent.**Semaphore;
>  import java.util.concurrent.TimeUnit;
>
> -import junit.framework.Assert;
> -
>  /**
>   * Collection of UI utilities.
>   */
> @@ -53,41 +51,4 @@ public class UiUtils {
>          instrumentation.**waitForIdleSync();
>          Thread.sleep(1000);
>      }
> -
> -    /**
> -     * Find the parent View for the Id across all activities, as dialogs
> -     * will be displayed in a separate activity. Note that in the case
> -     * of several views sharing the same ID across activities, this will
> -     * return the first view found.
> -     *
> -     * @param viewId The Id of the view.
> -     * @return the view which contains the given id or null if no view
> with the given id exists.
> -     */
> -    public static View findParentViewForIdAcrossActiv**ities(int viewId)
> {
> -        View[] availableViews = null;
> -        try {
> -            Class<?> windowManager = Class.forName("android.view.**
> WindowManagerImpl");
> -
> -            Field viewsField = windowManager.**
> getDeclaredField("mViews");
> -            Field instanceField = windowManager.**getDeclaredField("**
> sWindowManager");
> -            viewsField.setAccessible(true)**;
> -            instanceField.setAccessible(**true);
> -            Object instance = instanceField.get(null);
> -            availableViews = (View[]) viewsField.get(instance);
> -        } catch(Exception e) {
> -            Assert.fail("Could not fetch the available views.");
> -        }
> -
> -        if (availableViews == null || availableViews.length == 0) {
> -            return null;
> -        }
> -
> -        for (View view : availableViews) {
> -            if (view.findViewById(viewId) != null) {
> -                return view;
> -            }
> -        }
> -
> -        return null;
> -    }
>  }
>
>
>

[commit-bot: I haz the power, 2013-03-18 15:45:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12717011/1

[commit-bot: I haz the power, 2013-03-18 15:45:39]

Change committed as 188746