chrome/browser/task_manager/task_manager_notification_browsertest.cc - Issue 12712018: Fixing problem with incomplete browser windows showing up after task manager was used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_notification_browsertest.cc

Issue 12712018: Fixing problem with incomplete browser windows showing up after task manager was used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed again. Done. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/task_manager_browsertest_util.cc ('k') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_notification_browsertest.cc

diff --git a/chrome/browser/task_manager/task_manager_notification_browsertest.cc b/chrome/browser/task_manager/task_manager_notification_browsertest.cc

index d7667d353eb93756165fdac2a17beb62f3366f03..73f96571e4ec6cf4d1f7c8e9949a0a95f2cd2750 100644

--- a/chrome/browser/task_manager/task_manager_notification_browsertest.cc

+++ b/chrome/browser/task_manager/task_manager_notification_browsertest.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/browser/task_manager/task_manager_browsertest_util.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/ui_test_utils.h"

@@ -50,7 +51,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerNotificationBrowserTest,

EXPECT_EQ(0, model()->ResourceCount());

// Show the task manager.

- browser()->window()->ShowTaskManager();

+ chrome::ShowTaskManager(browser(), false);

// Expect to see the browser and the New Tab Page renderer.

TaskManagerBrowserTestUtil::WaitForWebResourceChange(1);

« no previous file with comments | « chrome/browser/task_manager/task_manager_browsertest_util.cc ('k') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('j') | no next file with comments »