Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 12710012: jar_file_jni_generator accepts jar_input_file optionally (Closed)

Created:
7 years, 9 months ago by ycheo (away)
Modified:
7 years, 9 months ago
Reviewers:
bulach, Torne
CC:
chromium-reviews
Visibility:
Public.

Description

jar_file_jni_generator accepts jar_input_file optionally BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190585

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M build/jar_file_jni_generator.gypi View 1 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ycheo (away)
Hi Marcus, With the recent CL, input_jar_file was removed. But, in my project, the variable ...
7 years, 9 months ago (2013-03-25 05:42:32 UTC) #1
bulach
lgtm, but please let torne verify his project too :)
7 years, 9 months ago (2013-03-25 13:46:00 UTC) #2
Torne
lgtm https://codereview.chromium.org/12710012/diff/1/build/jar_file_jni_generator.gypi File build/jar_file_jni_generator.gypi (right): https://codereview.chromium.org/12710012/diff/1/build/jar_file_jni_generator.gypi#newcode19 build/jar_file_jni_generator.gypi:19: # Optional varibales: nit: spelling (variables) :)
7 years, 9 months ago (2013-03-25 14:27:47 UTC) #3
ycheo (away)
https://codereview.chromium.org/12710012/diff/1/build/jar_file_jni_generator.gypi File build/jar_file_jni_generator.gypi (right): https://codereview.chromium.org/12710012/diff/1/build/jar_file_jni_generator.gypi#newcode19 build/jar_file_jni_generator.gypi:19: # Optional varibales: On 2013/03/25 14:27:47, Torne wrote: > ...
7 years, 9 months ago (2013-03-26 00:23:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ycheo@chromium.org/12710012/7001
7 years, 9 months ago (2013-03-26 00:26:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ycheo@chromium.org/12710012/7001
7 years, 9 months ago (2013-03-26 07:01:01 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 08:03:55 UTC) #7
Message was sent while issue was closed.
Change committed as 190585

Powered by Google App Engine
This is Rietveld 408576698