Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 12709003: Failing layout tests on Android shouldn't fail the whole bot. (Closed)

Created:
7 years, 9 months ago by Peter Beverloo
Modified:
7 years, 9 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Failing layout tests on Android shouldn't fail the whole bot. Output a warning instead of a failure when the layout test command fails. We'll revert this when we've got a stable base, and it will be easier for others to track webkit_unit_tests and TestWebKitAPI failurse until that happens. BUG=218257 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190135

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/buildbot/bb_device_steps.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Peter Beverloo
7 years, 9 months ago (2013-03-19 15:50:43 UTC) #1
Isaac (away)
What is the benefit of running these tests if nobody is watching the bot and ...
7 years, 9 months ago (2013-03-19 18:07:27 UTC) #2
Peter Beverloo
We'll know that we *can* run these tests. Let's not regress further and at least ...
7 years, 9 months ago (2013-03-19 18:10:40 UTC) #3
Isaac (away)
lgtm https://codereview.chromium.org/12709003/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/12709003/diff/1/build/android/buildbot/bb_device_steps.py#newcode243 build/android/buildbot/bb_device_steps.py:243: RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py'] + cmd_args, False) let's use named argument ...
7 years, 9 months ago (2013-03-19 18:11:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/12709003/7001
7 years, 9 months ago (2013-03-19 18:36:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=124478
7 years, 9 months ago (2013-03-19 20:15:17 UTC) #6
Isaac (away)
https://chromiumcodereview.appspot.com/12709003/diff/7001/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://chromiumcodereview.appspot.com/12709003/diff/7001/build/android/buildbot/bb_device_steps.py#newcode244 build/android/buildbot/bb_device_steps.py:244: flunk_on_failure=False) indentation?
7 years, 9 months ago (2013-03-19 20:29:48 UTC) #7
Peter Beverloo
Ack. Resubmitting.
7 years, 9 months ago (2013-03-21 18:36:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/12709003/16001
7 years, 9 months ago (2013-03-21 18:37:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/12709003/16001
7 years, 9 months ago (2013-03-22 18:35:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/12709003/16001
7 years, 9 months ago (2013-03-23 15:21:03 UTC) #11
commit-bot: I haz the power
7 years, 9 months ago (2013-03-24 00:28:36 UTC) #12
Message was sent while issue was closed.
Change committed as 190135

Powered by Google App Engine
This is Rietveld 408576698