bluetooth: Add histograms and logging for connectGATT

bluetooth: Add histograms and logging for connectGATT

Three new histograms:
 - ConnectGATT.Outcome: result of connectGATT() call.
 - ConnectGATT.TimeFailed: time it takes to fail to connect to a device
 - ConnectGATT.TimeSuccess: time it takes to successfully connect to a device

BUG=499636
Committed: https://crrev.com/1933ac776354301e9657637fad485be3deff01b5
Cr-Commit-Position: refs/heads/master@{#343142}

[ortuno, 2015-08-04 20:31:08]

Patchset #1 (id:1) has been deleted

[ortuno, 2015-08-04 20:31:12]

Patchset #1 (id:20001) has been deleted

[ortuno, 2015-08-11 23:33:47]

Patchset #1 (id:40001) has been deleted

[ortuno, 2015-08-11 23:33:51]

Patchset #1 (id:60001) has been deleted

[ortuno, 2015-08-11 23:34:05]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2015-08-11 23:34:05]

@jyasskin: PTAL

[Jeffrey Yasskin, 2015-08-12 00:35:45]

lgtm with the changes below.

https://codereview.chromium.org/1270603010/diff/80001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1270603010/diff/80001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:138:
UMA_HISTOGRAM_TIMES("Bluetooth.Web.ConnectGATT.TimeSuccess", duration);
I'm a little worried that 10 seconds won't be enough to catch the outliers in
connectGATT() timing. Maybe use UMA_HISTOGRAM_MEDIUM_TIMES(), to accommodate up
to 3 minutes.

https://codereview.chromium.org/1270603010/diff/80001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:464: device_instance_id,
base::TimeTicks::Now()),
Measure the starting time once at the beginning of this function, I think.

https://codereview.chromium.org/1270603010/diff/80001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:786: Send(new
BluetoothMsg_ConnectGATTError(thread_id, request_id,
Comment that RecordConnectGATTOutcome is called by TranslateConnectError.

https://codereview.chromium.org/1270603010/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1270603010/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2767: +<histogram
name="Bluetooth.Web.ConnectGATT.TimeFailed" units="seconds">
https://code.google.com/p/chromium/codesearch/#chromium/src/base/metrics/hist...
says these are both in milliseconds.

[ortuno, 2015-08-12 16:34:04]

Thanks!

https://codereview.chromium.org/1270603010/diff/80001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1270603010/diff/80001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:138:
UMA_HISTOGRAM_TIMES("Bluetooth.Web.ConnectGATT.TimeSuccess", duration);
On 2015/08/12 at 00:35:45, Jeffrey Yasskin wrote:
> I'm a little worried that 10 seconds won't be enough to catch the outliers in
connectGATT() timing. Maybe use UMA_HISTOGRAM_MEDIUM_TIMES(), to accommodate up
to 3 minutes.

Done.

https://codereview.chromium.org/1270603010/diff/80001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:464: device_instance_id,
base::TimeTicks::Now()),
On 2015/08/12 at 00:35:45, Jeffrey Yasskin wrote:
> Measure the starting time once at the beginning of this function, I think.

Done.

https://codereview.chromium.org/1270603010/diff/80001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:786: Send(new
BluetoothMsg_ConnectGATTError(thread_id, request_id,
On 2015/08/12 at 00:35:45, Jeffrey Yasskin wrote:
> Comment that RecordConnectGATTOutcome is called by TranslateConnectError.

Done.

https://codereview.chromium.org/1270603010/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1270603010/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2767: +<histogram
name="Bluetooth.Web.ConnectGATT.TimeFailed" units="seconds">
On 2015/08/12 at 00:35:45, Jeffrey Yasskin wrote:
>
https://code.google.com/p/chromium/codesearch/#chromium/src/base/metrics/hist...
says these are both in milliseconds.

Done.

[ortuno, 2015-08-12 16:34:19]

ortuno@chromium.org changed reviewers:
+ asvitkine@chromium.org

[ortuno, 2015-08-12 16:34:20]

@asvitkine: PTAL

[Alexei Svitkine (slow), 2015-08-12 17:13:28]

lgtm

[ortuno, 2015-08-12 17:13:52]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2015-08-12 17:13:52]

@scheib: PTAL

[scheib, 2015-08-12 21:09:17]

LGTM

[ortuno, 2015-08-12 22:27:31]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-12 22:28:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1270603010/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1270603010/120001

[commit-bot: I haz the power, 2015-08-12 23:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 23:43:42]

Dry run: This issue passed the CQ dry run.

[ortuno, 2015-08-13 01:22:24]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-08-13 01:22:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, asvitkine@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1270603010/#ps120001
(title: "Merge with ToT")

[commit-bot: I haz the power, 2015-08-13 01:22:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1270603010/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1270603010/120001

[commit-bot: I haz the power, 2015-08-13 01:26:59]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2015-08-13 01:27:39]

Patchset 3 (id:??) landed as
https://crrev.com/1933ac776354301e9657637fad485be3deff01b5
Cr-Commit-Position: refs/heads/master@{#343142}