Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc

Issue 12706012: chromeos: Destruct DriveResourceMetadata on the blocking pool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add note Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc
diff --git a/chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc b/chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc
index 66d8daf957ab5b0879d6323cf3f2143c5076e2a8..d979956d816ea3f5dfd9aaeaa5856c2cbfb193c0 100644
--- a/chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc
+++ b/chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc
@@ -57,14 +57,13 @@ class CreateDirectoryOperationTest
drive_web_apps_registry_.reset(new DriveWebAppsRegistry);
fake_free_disk_space_getter_.reset(new FakeFreeDiskSpaceGetter);
- cache_ = new DriveCache(
- DriveCache::GetCacheRootPath(profile_.get()),
- blocking_task_runner_,
- fake_free_disk_space_getter_.get());
+ cache_.reset(new DriveCache(DriveCache::GetCacheRootPath(profile_.get()),
+ blocking_task_runner_,
+ fake_free_disk_space_getter_.get()));
change_list_loader_.reset(new ChangeListLoader(
metadata_.get(), scheduler_.get(), drive_web_apps_registry_.get(),
- cache_));
+ cache_.get()));
DriveFileError error = DRIVE_FILE_OK;
change_list_loader_->LoadFromServerIfNeeded(
@@ -81,7 +80,7 @@ class CreateDirectoryOperationTest
virtual void TearDown() OVERRIDE {
operation_.reset();
change_list_loader_.reset();
- test_util::DeleteDriveCache(cache_);
+ cache_.reset();
fake_free_disk_space_getter_.reset();
drive_web_apps_registry_.reset();
scheduler_.reset();
@@ -128,14 +127,12 @@ class CreateDirectoryOperationTest
scoped_ptr<TestingProfile> profile_;
scoped_ptr<google_apis::FakeDriveService> fake_drive_service_;
- scoped_ptr<DriveResourceMetadata> metadata_;
+ scoped_ptr<DriveResourceMetadata, test_util::DestroyHelperForTests> metadata_;
scoped_ptr<DriveScheduler> scheduler_;
scoped_ptr<DriveWebAppsRegistry> drive_web_apps_registry_;
scoped_ptr<FakeFreeDiskSpaceGetter> fake_free_disk_space_getter_;
- // The way to delete the DriveCache instance is a bit tricky, so here we use
- // a raw point. See TearDown method for how to delete it.
- DriveCache* cache_;
+ scoped_ptr<DriveCache, test_util::DestroyHelperForTests> cache_;
scoped_ptr<ChangeListLoader> change_list_loader_;
scoped_ptr<CreateDirectoryOperation> operation_;
« no previous file with comments | « chrome/browser/chromeos/drive/drive_test_util.cc ('k') | chrome/browser/chromeos/drive/search_metadata_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698