Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: chrome/browser/chromeos/drive/drive_resource_metadata.h

Issue 12706012: chromeos: Destruct DriveResourceMetadata on the blocking pool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add note Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/drive_resource_metadata.h
diff --git a/chrome/browser/chromeos/drive/drive_resource_metadata.h b/chrome/browser/chromeos/drive/drive_resource_metadata.h
index 33729979d8d07821231940887bc33f7ca03a7f4e..af213b4ac502dc2f3b6f8a0da4dc1703e3891196 100644
--- a/chrome/browser/chromeos/drive/drive_resource_metadata.h
+++ b/chrome/browser/chromeos/drive/drive_resource_metadata.h
@@ -137,7 +137,10 @@ class DriveResourceMetadata {
DriveResourceMetadata(
const std::string& root_resource_id,
scoped_refptr<base::SequencedTaskRunner> blocking_task_runner);
- virtual ~DriveResourceMetadata();
+
+ // Destroys this object. This method posts a task to |blocking_task_runner_|
+ // to safely delete this object.
+ void Destroy();
// True if the file system feed is loaded from the cache or from the server.
bool loaded() const { return loaded_; }
@@ -234,6 +237,12 @@ class DriveResourceMetadata {
private:
friend class DriveResourceMetadataTest;
+ // Note: Use Destroy() to delete this object.
+ virtual ~DriveResourceMetadata();
+
+ // Used to implement Destroy().
+ void DestroyOnBlockingPool();
+
// Clears root_ and the resource map.
void ClearRoot();
« no previous file with comments | « chrome/browser/chromeos/drive/drive_file_system_util.h ('k') | chrome/browser/chromeos/drive/drive_resource_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698