Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 12704015: Explicitly pass the isolate to create handles in ic.cc (Closed)

Created:
7 years, 9 months ago by Toon Verwaest
Modified:
7 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Explicitly pass the isolate to create handles in ic.cc Committed: https://code.google.com/p/v8/source/detail?r=14007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M src/ic.cc View 19 chunks +27 lines, -21 lines 0 comments Download
M tools/grokdump.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 9 months ago (2013-03-20 13:08:51 UTC) #1
Sven Panne
lgtm
7 years, 9 months ago (2013-03-20 13:11:07 UTC) #2
Toon Verwaest
7 years, 9 months ago (2013-03-20 13:12:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698