Issue 12703026: [Telemetry] Don't include zombie processes in child process list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12703026: [Telemetry] Don't include zombie processes in child process list. (Closed)

Created:
7 years, 9 months ago by tonyg

Modified:
7 years, 9 months ago

Reviewers:
dtu, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Don't include zombie processes in child process list. This caused a flaky crash where Telemetry would sometimes grab the process list at the point a process had gone defunct, but before it actually stopped. BUG=223581 TEST=tools/perf/run_multipage_benchmarks -v --browser=exact --browser-executable=chrome/tools/test/reference_build/chrome_linux/chrome --output-trace-tag=_ref page_cycler tools/perf/page_sets/page_cycler/indexed_db/basic_insert.json NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190499

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	tools/telemetry/telemetry/core/chrome/linux_platform_backend.py	View		1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/12703026/1

7 years, 9 months ago (2013-03-25 22:40:45 UTC) #3

Message was sent while issue was closed.

Change committed as 190499

Expand Messages | Collapse Messages