Issue 12703020: Destroy NetworkChangeNotifier on the thread on which it is created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12703020: Destroy NetworkChangeNotifier on the thread on which it is created (Closed)

Created:
7 years, 9 months ago by Sergey Ulanov

Modified:
7 years, 9 months ago

Reviewers:
alexeypa (please no reviews)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Destroy NetworkChangeNotifier on the thread on which it is created Previously NetworkChangeNotifier was created on UI thread, but could be destroyed on some other random thread, which could cause the crash in the linked bug. Moved creation and destruction of the NetworkChangeNotifier to the network thread. BUG=179476 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190549

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	remoting/host/remoting_me2me_host.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/12703020/1

7 years, 9 months ago (2013-03-25 23:09:02 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=127381

7 years, 9 months ago (2013-03-26 01:25:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/12703020/1

7 years, 9 months ago (2013-03-26 01:30:10 UTC) #5

Message was sent while issue was closed.

Change committed as 190549

Expand Messages | Collapse Messages