Polymorphism support for numbers and strings

Polymorphism support for numbers and strings

Necessary to support fast polymorphic toString.

Committed: https://code.google.com/p/v8/source/detail?r=13914

[Toon Verwaest, 2013-03-11 15:20:44]

PTAL

[Jakob Kummerow, 2013-03-12 16:19:35]

LGTM with nits.

https://chromiumcodereview.appspot.com/12702002/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/12702002/diff/3001/src/hydrogen.cc#new...
src/hydrogen.cc:7406: HBasicBlock* number_branch = NULL;
A block is not a branch. Please call it number_block.

https://chromiumcodereview.appspot.com/12702002/diff/3001/src/hydrogen.cc#new...
src/hydrogen.cc:7415: HBasicBlock* smi_branch = graph()->CreateBasicBlock();
Same here. Also, in many places we follow the convention to make "empty" part of
the name of intentionally empty blocks; that would give you "empty_smi_block".

https://chromiumcodereview.appspot.com/12702002/diff/3001/src/hydrogen.cc#new...
src/hydrogen.cc:7439: HIsStringAndBranch* string_branch =
You don't need a separate variable here, just do:
      compare = new(zone()) HIsStringAndBranch(receiver);
      compare->SetSuccessorAt(...);

[Toon Verwaest, 2013-03-12 17:00:28]

Addressed comments.

https://chromiumcodereview.appspot.com/12702002/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/12702002/diff/3001/src/hydrogen.cc#new...
src/hydrogen.cc:7406: HBasicBlock* number_branch = NULL;
On 2013/03/12 16:19:35, Jakob wrote:
> A block is not a branch. Please call it number_block.

Done.

https://chromiumcodereview.appspot.com/12702002/diff/3001/src/hydrogen.cc#new...
src/hydrogen.cc:7415: HBasicBlock* smi_branch = graph()->CreateBasicBlock();
On 2013/03/12 16:19:35, Jakob wrote:
> Same here. Also, in many places we follow the convention to make "empty" part
of
> the name of intentionally empty blocks; that would give you "empty_smi_block".

Done.

https://chromiumcodereview.appspot.com/12702002/diff/3001/src/hydrogen.cc#new...
src/hydrogen.cc:7439: HIsStringAndBranch* string_branch =
On 2013/03/12 16:19:35, Jakob wrote:
> You don't need a separate variable here, just do:
>       compare = new(zone()) HIsStringAndBranch(receiver);
>       compare->SetSuccessorAt(...);

Done.

[Toon Verwaest, 2013-03-12 17:01:08]

Committed patchset #2 manually as r13914 (presubmit successful).