Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issue 12700016: [Sync] Add favicon sync experiment (Closed)

Created:
7 years, 9 months ago by Nicolas Zea
Modified:
7 years, 9 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Add favicon sync experiment The old tab sync favicon experiment is deprecated. This patch updates the strings to the fact that we now have a separate datatype, and hooks this up to a new sync field. BUG=154886 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188974

Patch Set 1 #

Patch Set 2 : Self review #

Total comments: 2

Patch Set 3 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -42 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 chunks +6 lines, -12 lines 0 comments Download
M sync/internal_api/public/util/experiments.h View 2 chunks +11 lines, -10 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M sync/protocol/experiments_specifics.proto View 2 chunks +6 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 1 2 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nicolas Zea
PTAL
7 years, 9 months ago (2013-03-18 18:39:16 UTC) #1
rlarocque
lgtm https://codereview.chromium.org/12700016/diff/2001/sync/protocol/proto_value_conversions.cc File sync/protocol/proto_value_conversions.cc (right): https://codereview.chromium.org/12700016/diff/2001/sync/protocol/proto_value_conversions.cc#newcode111 sync/protocol/proto_value_conversions.cc:111: proto.field().has_enabled()) { \ nit: align slashes.
7 years, 9 months ago (2013-03-18 18:48:11 UTC) #2
Nicolas Zea
Thanks for the quick review! Done, committing. https://codereview.chromium.org/12700016/diff/2001/sync/protocol/proto_value_conversions.cc File sync/protocol/proto_value_conversions.cc (right): https://codereview.chromium.org/12700016/diff/2001/sync/protocol/proto_value_conversions.cc#newcode111 sync/protocol/proto_value_conversions.cc:111: proto.field().has_enabled()) { ...
7 years, 9 months ago (2013-03-18 19:12:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/12700016/6001
7 years, 9 months ago (2013-03-18 19:13:22 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=124134
7 years, 9 months ago (2013-03-19 01:26:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/12700016/6001
7 years, 9 months ago (2013-03-19 02:50:53 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 09:58:41 UTC) #7
Message was sent while issue was closed.
Change committed as 188974

Powered by Google App Engine
This is Rietveld 408576698