Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 12700005: Support large_changestamp on GetAboutResource and GetAccountMetadata. (Closed)

Created:
7 years, 9 months ago by hidehiko
Modified:
7 years, 9 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Support large_changestamp on GetAboutResource and GetAccountMetadata. At the moment, no clients take care about that the largest_changestamp in GetAboutResource/GetAccountMetadata is updated or not. However, in following change, it will be indirectly used. So fix the problem at first. BUG=174237 TEST=Ran unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -9 lines) Patch
M chrome/browser/google_apis/fake_drive_service.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service_unittest.cc View 16 chunks +64 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 9 months ago (2013-03-11 08:13:12 UTC) #1
kinaba
good catch! lgtm.
7 years, 9 months ago (2013-03-11 08:38:10 UTC) #2
hashimoto
lgtm
7 years, 9 months ago (2013-03-11 08:45:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12700005/1
7 years, 9 months ago (2013-03-11 08:47:02 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 11:00:33 UTC) #5
Message was sent while issue was closed.
Change committed as 187271

Powered by Google App Engine
This is Rietveld 408576698