Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 12699003: [MIPS] Set CXX variable used for v8 build (Closed)

Created:
7 years, 9 months ago by petarj
Modified:
7 years, 9 months ago
Reviewers:
tony
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[MIPS] Set CXX variable used for v8 build This change sets CXX gyp variable for target_arch=="mipsel". It is a follow up of the change in v8, and it resolves issue of incorrectly passed m32 flag to MIPS cross toolchain. Full discussion with Jakob Kummerow and related v8 change can be seen at: https://codereview.chromium.org/12218113/ BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187124

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove CXX definition from global scope. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/common.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petarj
7 years, 9 months ago (2013-03-08 17:19:52 UTC) #1
tony
https://codereview.chromium.org/12699003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12699003/diff/1/build/common.gypi#newcode619 build/common.gypi:619: 'CXX%': '<!(cd <(DEPTH) && pwd -P)/mipsel-sysroot/bin/mipsel-linux-gnu-gcc', Do we need ...
7 years, 9 months ago (2013-03-08 17:49:28 UTC) #2
petarj
https://codereview.chromium.org/12699003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12699003/diff/1/build/common.gypi#newcode619 build/common.gypi:619: 'CXX%': '<!(cd <(DEPTH) && pwd -P)/mipsel-sysroot/bin/mipsel-linux-gnu-gcc', On 2013/03/08 17:49:28, ...
7 years, 9 months ago (2013-03-08 18:44:39 UTC) #3
tony
LGTM
7 years, 9 months ago (2013-03-08 19:05:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/12699003/3002
7 years, 9 months ago (2013-03-08 23:23:17 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-09 02:51:33 UTC) #6
Message was sent while issue was closed.
Change committed as 187124

Powered by Google App Engine
This is Rietveld 408576698