Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 12696006: search box text change in apps_Devtools app. (Closed)

Created:
7 years, 9 months ago by Gaurav
Modified:
7 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

search box text change in apps_Devtools app. BUG=149036 TBR=asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191161

Patch Set 1 #

Total comments: 2

Patch Set 2 : added translation for searchbox text #

Total comments: 5

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/apps_debugger/js/items_list.js View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/apps_debugger/main.html View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Gaurav
7 years, 9 months ago (2013-03-18 23:06:32 UTC) #1
Dan Beam
https://chromiumcodereview.appspot.com/12696006/diff/1/chrome/browser/resources/apps_debugger/main.html File chrome/browser/resources/apps_debugger/main.html (right): https://chromiumcodereview.appspot.com/12696006/diff/1/chrome/browser/resources/apps_debugger/main.html#newcode40 chrome/browser/resources/apps_debugger/main.html:40: <input id="search" type="text" placeholder="search" where is the translation here? ...
7 years, 9 months ago (2013-03-18 23:17:07 UTC) #2
Gaurav
7 years, 9 months ago (2013-03-20 19:00:15 UTC) #3
Dan Beam
https://chromiumcodereview.appspot.com/12696006/diff/1/chrome/browser/resources/apps_debugger/main.html File chrome/browser/resources/apps_debugger/main.html (right): https://chromiumcodereview.appspot.com/12696006/diff/1/chrome/browser/resources/apps_debugger/main.html#newcode40 chrome/browser/resources/apps_debugger/main.html:40: <input id="search" type="text" placeholder="search" On 2013/03/18 23:17:07, Dan Beam ...
7 years, 9 months ago (2013-03-20 19:05:55 UTC) #4
Gaurav
https://chromiumcodereview.appspot.com/12696006/diff/4001/chrome/browser/resources/apps_debugger/main.html File chrome/browser/resources/apps_debugger/main.html (right): https://chromiumcodereview.appspot.com/12696006/diff/4001/chrome/browser/resources/apps_debugger/main.html#newcode41 chrome/browser/resources/apps_debugger/main.html:41: i18n-values=".placeholder:appsDevtoolSearch" spellcheck="false"> translation added here.
7 years, 9 months ago (2013-03-26 23:06:43 UTC) #5
Dan Beam
lgtm w/nit and better [desc] https://chromiumcodereview.appspot.com/12696006/diff/4001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/12696006/diff/4001/chrome/app/generated_resources.grd#newcode5348 chrome/app/generated_resources.grd:5348: + <message name="IDS_APPS_DEVTOOL_SEARCH" desc="Text ...
7 years, 9 months ago (2013-03-27 00:11:40 UTC) #6
Gaurav
https://codereview.chromium.org/12696006/diff/4001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/12696006/diff/4001/chrome/app/generated_resources.grd#newcode5348 chrome/app/generated_resources.grd:5348: + <message name="IDS_APPS_DEVTOOL_SEARCH" desc="Text of the search box."> On ...
7 years, 9 months ago (2013-03-27 17:58:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12696006/12001
7 years, 9 months ago (2013-03-27 17:59:28 UTC) #8
commit-bot: I haz the power
Presubmit check for 12696006-12001 failed and returned exit status 1. INFO:root:Found 4 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-27 17:59:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12696006/12001
7 years, 9 months ago (2013-03-27 19:06:10 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=128297
7 years, 9 months ago (2013-03-28 00:18:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12696006/12001
7 years, 8 months ago (2013-03-28 17:23:05 UTC) #12
commit-bot: I haz the power
7 years, 8 months ago (2013-03-28 17:25:54 UTC) #13
Message was sent while issue was closed.
Change committed as 191161

Powered by Google App Engine
This is Rietveld 408576698