Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 12695010: Remove webkit/compositor_bindings from PRESUBMIT exclusion list (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Remove webkit/compositor_bindings from PRESUBMIT exclusion list This was added when initially importing this code from WebKit that didn't comply with chromium's style rules. This code now passes lint and presubmit checks so there's no need for the exclusion. NOTRY=true BUG=144577 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
7 years, 9 months ago (2013-03-19 16:00:25 UTC) #1
M-A Ruel
lgtm
7 years, 9 months ago (2013-03-19 16:02:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12695010/1
7 years, 9 months ago (2013-03-19 16:02:31 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 16:04:12 UTC) #4
Message was sent while issue was closed.
Change committed as 189029

Powered by Google App Engine
This is Rietveld 408576698